Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: chrome/browser/ui/autofill/password_generation_popup_controller.h

Issue 147533005: [Password Generation] Update UI to match final mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replace_password_generation_ui
Patch Set: Unittests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "chrome/browser/ui/autofill/autofill_popup_view_delegate.h" 9 #include "chrome/browser/ui/autofill/autofill_popup_view_delegate.h"
10 10
11 namespace gfx {
12 class FontList;
13 class Range;
14 }
15
11 namespace autofill { 16 namespace autofill {
12 17
13 class PasswordGenerationPopupController : public AutofillPopupViewDelegate { 18 class PasswordGenerationPopupController : public AutofillPopupViewDelegate {
14 public: 19 public:
15 // Space above and below the password section. 20 // Space above and below the password section.
16 static const int kPasswordVerticalPadding = 14; 21 static const int kPasswordVerticalPadding = 16;
17 22
18 // Space above and below help section. 23 // Space above and below help section.
19 static const int kHelpVerticalPadding = 15; 24 static const int kHelpVerticalPadding = 15;
20 25
21 // Spacing between the border of the popup and any text. 26 // Spacing between the border of the popup and any text.
22 static const int kHorizontalPadding = 9; 27 static const int kHorizontalPadding = 10;
23 28
24 // Called by the view when the help link is clicked. 29 // Called by the view when the saved passwords link is clicked.
25 virtual void OnHelpLinkClicked() = 0; 30 virtual void OnSavedPasswordsLinkClicked() = 0;
26 31
27 // Accessors 32 // Accessors
33 virtual const gfx::FontList& font_list() const = 0;
28 virtual const gfx::Rect& password_bounds() const = 0; 34 virtual const gfx::Rect& password_bounds() const = 0;
29 virtual const gfx::Rect& divider_bounds() const = 0; 35 virtual const gfx::Rect& divider_bounds() const = 0;
30 virtual const gfx::Rect& help_bounds() const = 0; 36 virtual const gfx::Rect& help_bounds() const = 0;
37 virtual bool display_password() const = 0;
31 virtual bool password_selected() const = 0; 38 virtual bool password_selected() const = 0;
32 virtual base::string16 password() const = 0; 39 virtual base::string16 password() const = 0;
33 40
34 // Translated strings 41 // Translated strings
35 virtual base::string16 HelpText() = 0; 42 virtual base::string16 SuggestedText() = 0;
36 virtual base::string16 LearnMoreLink() = 0; 43 virtual const base::string16& HelpText() = 0;
44 virtual const gfx::Range& HelpTextLinkRange() = 0;
37 45
38 protected: 46 protected:
39 virtual ~PasswordGenerationPopupController() {} 47 virtual ~PasswordGenerationPopupController() {}
40 }; 48 };
41 49
42 } // namespace autofill 50 } // namespace autofill
43 51
44 #endif // CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_H_ 52 #endif // CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698