Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: components/autofill/core/common/password_generation_util.h

Issue 147533005: [Password Generation] Update UI to match final mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replace_password_generation_ui
Patch Set: Merge Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_
6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_ 6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_
7 7
8 namespace autofill { 8 namespace autofill {
9 namespace password_generation { 9 namespace password_generation {
10 10
11 // Enumerates various events related to the password generation process. 11 // Enumerates various events related to the password generation process.
12 // Do not remove items from this enum as they are used for UMA stats logging.
12 enum PasswordGenerationEvent { 13 enum PasswordGenerationEvent {
13 // No Account creation form is detected. 14 // No Account creation form is detected.
14 NO_SIGN_UP_DETECTED, 15 NO_SIGN_UP_DETECTED,
15 16
16 // Account creation form is detected. 17 // Account creation form is detected.
17 SIGN_UP_DETECTED, 18 SIGN_UP_DETECTED,
18 19
19 // Password generation icon is shown inside the first password field. 20 // DEPRECATED: Password generation icon shown (old UI).
20 ICON_SHOWN, 21 DEPRECATED_ICON_SHOWN,
21 22
22 // Password generation bubble is shown after user clicks on the icon. 23 // DEPRECATED: Password generation bubble shown (old UI).
23 BUBBLE_SHOWN, 24 DEPRECATED_BUBBLE_SHOWN,
25
26 // Password generation could be triggered if the user selects the appropriate
27 // element.
28 GENERATION_AVAILABLE,
29
30 // Password generation popup is shown after user focuses the appropriate
31 // password field.
32 GENERATION_POPUP_SHOWN,
33
34 // Generated password was accepted by the user.
35 PASSWORD_ACCEPTED,
36
37 // User focused the password field containing the generated password.
38 EDITING_POPUP_SHOWN,
39
40 // Password was changed after generation.
41 PASSWORD_EDITED,
42
43 // Generated password was deleted by the user
44 PASSWORD_DELETED,
24 45
25 // Number of enum entries, used for UMA histogram reporting macros. 46 // Number of enum entries, used for UMA histogram reporting macros.
26 EVENT_ENUM_COUNT 47 EVENT_ENUM_COUNT
27 }; 48 };
28 49
29 // Wrapper to store the user interactions with the password generation bubble. 50 // Wrapper to store the user interactions with the password generation bubble.
30 struct PasswordGenerationActions { 51 struct PasswordGenerationActions {
31 // Whether the user has clicked on the learn more link. 52 // Whether the user has clicked on the learn more link.
32 bool learn_more_visited; 53 bool learn_more_visited;
33 54
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 }; 93 };
73 94
74 // Returns true if Password Generation is enabled according to the field 95 // Returns true if Password Generation is enabled according to the field
75 // trial result and the flags. 96 // trial result and the flags.
76 bool IsPasswordGenerationEnabled(); 97 bool IsPasswordGenerationEnabled();
77 98
78 } // namespace password_generation 99 } // namespace password_generation
79 } // namespace autofill 100 } // namespace autofill
80 101
81 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_ 102 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698