Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4532)

Unified Diff: chrome/chrome_android.gypi

Issue 147533004: Remove unneeded JNI registrations. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Fix android webview build issues. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_android.gypi
diff --git a/chrome/chrome_android.gypi b/chrome/chrome_android.gypi
index 48e8cdb08593cb8da12b1da5aaf9ae45a6136f23..cdbac6cd7b2768ba7027a78b818b5b789e5726da 100644
--- a/chrome/chrome_android.gypi
+++ b/chrome/chrome_android.gypi
@@ -44,6 +44,19 @@
'dependencies': [
'../base/allocator/allocator.gyp:allocator', ],
}],
+ ['component == "static_library"', {
+ 'ldflags!': [
+ # Don't need to strip symbols from libs, because exports are controlled
+ # through linker vesrion script.
+ '-Wl,--exclude-libs=ALL',
+ ],
+ 'ldflags': [
+ # Android exports in linker version script.
+ # TODO(ostap): Gyp doesn't corectly calculate path if <(DEPTH) is used here.
+ # Use <(DEPTH) when gyp is fixed or replaced with gn.
+ '-Wl,--version-script="../../build/android/android_exports.lst"',
Yaron 2014/04/02 21:02:53 Why not do this everywhere (build/common.gypi)? Th
+ ],
+ }],
],
},
{

Powered by Google App Engine
This is Rietveld 408576698