Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 147533002: [refactor] Split up some large switch statements. (Closed)

Created:
6 years, 11 months ago by eroman
Modified:
6 years, 10 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[refactor] Split up some large switch statements. BUG=245025 R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248108

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Patch Set 3 : Rebase again for funzies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -367 lines) Patch
M content/renderer/webcrypto/webcrypto_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webcrypto/webcrypto_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_nss.cc View 1 7 chunks +453 lines, -363 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_openssl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
eroman
https://codereview.chromium.org/147533002/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc (right): https://codereview.chromium.org/147533002/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc#newcode697 content/renderer/webcrypto/webcrypto_impl_nss.cc:697: Status SignHmac( All of this code should be unchanged ...
6 years, 11 months ago (2014-01-25 02:20:18 UTC) #1
Ryan Sleevi
LGTM Great cleanup https://codereview.chromium.org/147533002/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc (right): https://codereview.chromium.org/147533002/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc#newcode1156 content/renderer/webcrypto/webcrypto_impl_nss.cc:1156: case blink::WebCryptoAlgorithmIdRsaEsPkcs1v1_5: In a future cleanup, ...
6 years, 11 months ago (2014-01-25 02:42:21 UTC) #2
eroman
https://codereview.chromium.org/147533002/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc (right): https://codereview.chromium.org/147533002/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc#newcode1156 content/renderer/webcrypto/webcrypto_impl_nss.cc:1156: case blink::WebCryptoAlgorithmIdRsaEsPkcs1v1_5: On 2014/01/25 02:42:21, Ryan Sleevi wrote: > ...
6 years, 11 months ago (2014-01-25 02:46:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/147533002/80001
6 years, 10 months ago (2014-01-30 23:02:13 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 23:12:59 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on linux_rel HTTP Error 400: Bad Request
6 years, 10 months ago (2014-01-30 23:29:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/147533002/100001
6 years, 10 months ago (2014-01-30 23:29:27 UTC) #7
eroman
Committed patchset #3 manually as r248108 (presubmit successful).
6 years, 10 months ago (2014-01-31 02:14:26 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 02:14:30 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 02:14:41 UTC) #10
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698