Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 14753011: Android WebView: tidy up library dependencies. (Closed)

Created:
7 years, 7 months ago by Torne
Modified:
7 years, 7 months ago
Reviewers:
digit1
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, android-webview-reviews_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android WebView: tidy up library dependencies. The comment in android_webview.gyp about static library dependencies not being handled correctly is incorrect, and the workaround not necessary: the problem was just that I wasn't using link_settings correctly. Remove the workaround and instead add proper dependencies in the places that actually use cpufeatures and cutils (ashmem). This doesn't change the generated makefiles but makes more logical sense. BUG= R=digit@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M build/android/cpufeatures.gypi View 1 chunk +12 lines, -1 line 0 comments Download
M third_party/ashmem/ashmem.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
Hi David, can you take a look at this since you're the OWNER for third_party/ashmem ...
7 years, 7 months ago (2013-05-08 13:55:18 UTC) #1
Torne
ping.. :) If you just want to rubberstamp this for the ashmem change I can ...
7 years, 7 months ago (2013-05-17 10:35:47 UTC) #2
digit1
lgtm, sorry I was on vacation last week, and didn't see this (email too large ...
7 years, 7 months ago (2013-05-17 11:29:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/14753011/1
7 years, 7 months ago (2013-05-17 11:30:59 UTC) #4
Torne
7 years, 7 months ago (2013-05-17 13:46:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r200806 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698