Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Unified Diff: pkg/scheduled_test/lib/src/mock_clock.dart

Issue 14753009: Make StreamSubscription be the active part of a stream. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/scheduled_test/lib/scheduled_process.dart ('k') | pkg/scheduled_test/lib/src/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/lib/src/mock_clock.dart
diff --git a/pkg/scheduled_test/lib/src/mock_clock.dart b/pkg/scheduled_test/lib/src/mock_clock.dart
index 6abe81f155031ca75d4c4b68114b4b9eb725c2d1..c80a9552661329cf8e4402afdb4bddf75652d473 100644
--- a/pkg/scheduled_test/lib/src/mock_clock.dart
+++ b/pkg/scheduled_test/lib/src/mock_clock.dart
@@ -44,27 +44,43 @@ class Clock {
int get time => _time;
int _time = 0;
+ /// Collection of controllers of all subscribed listeners.
+ ///
+ /// [StreamController] is not overriding [Object.operator==], so this is
+ /// effectively an identity map.
+ Set<StreamController> _subscriptions = new Set<StreamController>();
+
+ Clock._();
+
/// The stream of millisecond ticks of the clock.
Stream<int> get onTick {
- if (_onTickControllerStream == null) {
- _onTickControllerStream = _onTickController.stream.asBroadcastStream();
- }
- return _onTickControllerStream;
+ StreamController<int> controller;
+ controller = new StreamController<int>(
+ onListen: () {
+ _subscriptions.add(controller);
+ },
+ onCancel: () {
+ _subscriptions.remove(controller);
+ });
+ return controller.stream;
}
- final _onTickController = new StreamController<int>();
- Stream<int> _onTickControllerStream;
-
- Clock._();
/// Advances the clock forward by [milliseconds]. This works like synchronous
/// code that takes [milliseconds] to execute; any [Timer]s that are scheduled
/// to fire during the interval will do so asynchronously once control returns
/// to the event loop.
- void tick([int milliseconds=1]) {
+ void tick([int milliseconds = 1]) {
for (var i = 0; i < milliseconds; i++) {
var tickTime = ++_time;
- new Future.value().then((_) => _onTickController.add(tickTime));
+ runAsync(() {
+ List<StreamController> controllers = _subscriptions.toList();
+ for (StreamController controller in controllers) {
+ if (_subscriptions.contains(controller)) {
+ controller.add(tickTime);
+ }
+ }
+ });
}
}
@@ -74,7 +90,7 @@ class Clock {
/// code runs before the next tick.
void run() {
pumpEventQueue().then((_) {
- if (!_onTickController.hasListener) return;
+ if (_subscriptions.isEmpty) return;
tick();
return run();
});
« no previous file with comments | « pkg/scheduled_test/lib/scheduled_process.dart ('k') | pkg/scheduled_test/lib/src/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698