runtime/bin/socket_patch.dart - Issue 14753009: Make StreamSubscription be the active part of a stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_patch.dart

Issue 14753009: Make StreamSubscription be the active part of a stream. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove remaining debugging prints. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/scheduled_test/lib/src/utils.dart ('K') | « pkg/scheduled_test/lib/src/utils.dart ('k') | sdk/lib/_internal/pub/lib/src/error_group.dart » ('j') | sdk/lib/_internal/pub/test/error_group_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/socket_patch.dart

diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart

index f233a982789d4ad4d18f2c88aba3147a9118a9ea..d86a17c1d8de72491c92c29d068310286db63a87 100644

--- a/runtime/bin/socket_patch.dart

+++ b/runtime/bin/socket_patch.dart

@@ -837,11 +837,6 @@ class _SocketStreamConsumer extends StreamConsumer<List<int>> {

if (offset < buffer.length) {

if (!paused) {

paused = true;

- // TODO(ajohnsen): It would be nice to avoid this check.

- // Some info: socket._write can emit an event, if it fails to write.

- // If the user closes the socket in that event, stop() will be called

- // before we get a change to pause.

- if (subscription == null) return;

subscription.pause();

}

socket._enableWriteEvent();

@@ -874,6 +869,7 @@ class _SocketStreamConsumer extends StreamConsumer<List<int>> {

if (subscription == null) return;

subscription.cancel();

subscription = null;

+ paused = false;

socket._disableWriteEvent();

}