Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 14753008: Revert 198867 "Gets the initial sync service status. In the next..." (Closed)

Created:
7 years, 7 months ago by Finnur
Modified:
7 years, 7 months ago
Reviewers:
calvinlo
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 198867 "Gets the initial sync service status. In the next..." Reason: Compile failure on Android. > Gets the initial sync service status. In the next patch I'll make the syncfs-internals dashboard a sync_event_observer so it can also report changes in real time (as they come by notification). > > BUG=226353 > TEST=open chrome://syncfs-internals. Service status should be running if signed in. Should be authentication_required if not signed in and any SyncFS app is run (i.e. calls requestFileSystem at least once). > > Please not that the page has to be refreshed manually to get updated values for now. > > R=arv@chromium.org, kinuko@chromium.org, tzik@chromium.org > > Review URL: https://codereview.chromium.org/14765003 TBR=calvinlo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -197 lines) Patch
M trunk/src/chrome/browser/resources/sync_file_system_internals/main.css View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/resources/sync_file_system_internals/main.html View 1 chunk +4 lines, -1 line 0 comments Download
D trunk/src/chrome/browser/resources/sync_file_system_internals/sync_service.html View 1 chunk +0 lines, -11 lines 0 comments Download
D trunk/src/chrome/browser/resources/sync_file_system_internals/sync_service.js View 1 chunk +0 lines, -43 lines 0 comments Download
M trunk/src/chrome/browser/resources/sync_file_system_internals_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.h View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/src/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D trunk/src/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_ui.h View 1 chunk +0 lines, -18 lines 0 comments Download
D trunk/src/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_ui.cc View 1 chunk +0 lines, -38 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/sync_file_system_internals_ui.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/sync_file_system_internals_ui.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
7 years, 7 months ago (2013-05-08 09:58:43 UTC) #1
Finnur
7 years, 7 months ago (2013-05-08 09:58:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r198869.

Powered by Google App Engine
This is Rietveld 408576698