Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Issue 1475293003: Move IDS_FLAGS_ENHANCED_BOOKMARKS_{NAME,DESCRIPTION} to components_strings. (Closed)

Created:
5 years ago by sdefresne
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move IDS_FLAGS_ENHANCED_BOOKMARKS_{NAME,DESCRIPTION} to components_strings. Move the strings IDS_FLAGS_ENHANCED_BOOKMARKS_{NAME,DESCRIPTION} to //components/strings so that they can be shared with iOS. BUG=551954 Committed: https://crrev.com/ed25e27ac2c6bbcabc7a7908f802a8e74b5ee11c Cr-Commit-Position: refs/heads/master@{#361908}

Patch Set 1 #

Patch Set 2 : Add reference to enhanced_bookmarks_strings.grdp in components/components_strings.grd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M components/components_strings.grd View 1 1 chunk +1 line, -0 lines 0 comments Download
A components/enhanced_bookmarks_strings.grdp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sdefresne
Please take a look.
5 years ago (2015-11-26 14:47:15 UTC) #2
noyau (Ping after 24h)
lgtm
5 years ago (2015-11-26 14:48:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475293003/20001
5 years ago (2015-11-26 16:14:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 17:22:52 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-26 17:23:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed25e27ac2c6bbcabc7a7908f802a8e74b5ee11c
Cr-Commit-Position: refs/heads/master@{#361908}

Powered by Google App Engine
This is Rietveld 408576698