Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1475233002: Remove base::enable_if (Closed)

Created:
5 years ago by vmpstr
Modified:
5 years ago
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::enable_if This patch removes base::enable_if in favor of std::enable_if R=thakis@chromium.org Committed: https://crrev.com/98a2fada78e6b57558c492cd889a12d0ba87636c Cr-Commit-Position: refs/heads/master@{#362206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -93 lines) Patch
M base/callback_internal.h View 1 chunk +4 lines, -2 lines 0 comments Download
M base/numerics/safe_conversions.h View 3 chunks +4 lines, -3 lines 0 comments Download
M base/numerics/safe_math.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/numerics/safe_math_impl.h View 20 chunks +63 lines, -59 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M base/template_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_helper.h View 2 chunks +5 lines, -6 lines 0 comments Download
M gin/object_template_builder.h View 2 chunks +6 lines, -3 lines 0 comments Download
M gin/wrappable.h View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vmpstr
Please take a look.
5 years ago (2015-11-25 20:51:58 UTC) #1
Nico
lgtm
5 years ago (2015-11-25 20:56:15 UTC) #2
vmpstr
+jochen for gin/, please take a look.
5 years ago (2015-11-25 20:58:30 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-11-26 13:24:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475233002/1
5 years ago (2015-11-30 18:18:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 20:15:29 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-30 20:16:08 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/98a2fada78e6b57558c492cd889a12d0ba87636c
Cr-Commit-Position: refs/heads/master@{#362206}

Powered by Google App Engine
This is Rietveld 408576698