Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: runtime/bin/builtin_nolib.cc

Issue 14752008: Final step towards loading core library scripts directly from the sources (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/builtin_natives.cc ('k') | runtime/bin/dartutils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/builtin_nolib.cc
===================================================================
--- runtime/bin/builtin_nolib.cc (revision 22513)
+++ runtime/bin/builtin_nolib.cc (working copy)
@@ -22,21 +22,20 @@
Dart_Handle Builtin::Source(BuiltinLibraryId id) {
- ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
- kInvalidLibrary);
return Dart_NewApiError("Unreachable code in Builtin::Source (%d).", id);
}
-/**
- * Looks up native functions in both libdart_builtin and libdart_io.
- */
-Dart_NativeFunction Builtin::NativeLookup(Dart_Handle name,
- int argument_count) {
- Dart_NativeFunction result = BuiltinNativeLookup(name, argument_count);
- if (result != NULL) return result;
- return IONativeLookup(name, argument_count);
+
+Dart_Handle Builtin::PartSource(BuiltinLibraryId id, const char* uri) {
+ return Dart_NewApiError("Unreachable code in Builtin::PartSource (%d).", id);
}
+
+Dart_Handle Builtin::GetSource(const char** source_paths, const char* uri) {
+ return Dart_NewApiError("Unreachable code in Builtin::GetSource (%s).", uri);
+}
+
+
void Builtin::SetNativeResolver(BuiltinLibraryId id) {
ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
kInvalidLibrary);
@@ -57,14 +56,6 @@
ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary);
Dart_Handle url = DartUtils::NewString(builtin_libraries_[id].url_);
Dart_Handle library = Dart_LookupLibrary(url);
- if (Dart_IsError(library)) {
- ASSERT(id > kIOLibrary);
- library = Dart_LoadLibrary(url, Source(id));
- if (!Dart_IsError(library) && (builtin_libraries_[id].has_natives_)) {
- // Setup the native resolver for built in library functions.
- DART_CHECK_VALID(Dart_SetNativeResolver(library, NativeLookup));
- }
- }
DART_CHECK_VALID(library);
return library;
}
« no previous file with comments | « runtime/bin/builtin_natives.cc ('k') | runtime/bin/dartutils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698