Fix downloading of LLVM Gold plugin for the official Chrome.

Fix downloading of LLVM Gold plugin for the official Chrome.

The build needs the plugin to make an LTO build, which will soon
be the default for the official Chrome as a part of
Control Flow Integrity launch. See
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
for more details.

BUG=chromium:464797
Committed: https://crrev.com/9ddd19577633e02c8c6f6ae83ee5efd9e2c4c567
Cr-Commit-Position: refs/heads/master@{#361774}

[krasin, 2015-11-25 19:27:13]

krasin@google.com changed reviewers:
+ thakis@chromium.org

[krasin, 2015-11-25 19:27:13]

Hi Nico,

it seems that I have found one more blocker for the CFI launch, but this time
it's a toy one.

Not sure why I was not hit by this issue a month ago.

[Nico, 2015-11-25 19:39:30]

lgtm

[krasin, 2015-11-25 19:39:59]

The CQ bit was checked by krasin@google.com

[Nico, 2015-11-25 19:40:22]

...dpranke, are the official linux builds on gn by now? In the gn build, is
there some env var to know if an official build is happening, or some other way
to query for that?

[commit-bot: I haz the power, 2015-11-25 19:41:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1475173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1475173002/1

[Dirk Pranke, 2015-11-25 20:31:14]

On 2015/11/25 19:40:22, Nico wrote:
> ...dpranke, are the official linux builds on gn by now? In the gn build, is
> there some env var to know if an official build is happening, or some other
way
> to query for that?

The 64-bit build is on GN, but the 32-bit build is not.

If you need to query the environment at runhooks time (which is when this is
called, right?), you should still look
either branding=Chrome or buildtype=Official in GYP_DEFINES, even on builds that
are using MB and/or GN.

We will need to come up with a new mechanism for passing parameters to hooks
that doesn't rely on GYP_DEFINES
in the environment when we completely move off of GYP, but we don't have one
yet.

[Nico, 2015-11-25 20:36:23]

Ok, sounds like this should work for now then. Thanks!

On Wed, Nov 25, 2015 at 3:31 PM, <dpranke@chromium.org> wrote:

> On 2015/11/25 19:40:22, Nico wrote:
>
>> ...dpranke, are the official linux builds on gn by now? In the gn build,
>> is
>> there some env var to know if an official build is happening, or some
>> other
>>
> way
>
>> to query for that?
>>
>
> The 64-bit build is on GN, but the 32-bit build is not.
>
> If you need to query the environment at runhooks time (which is when this
> is
> called, right?), you should still look
> either branding=Chrome or buildtype=Official in GYP_DEFINES, even on
> builds that
> are using MB and/or GN.
>
> We will need to come up with a new mechanism for passing parameters to
> hooks
> that doesn't rely on GYP_DEFINES
> in the environment when we completely move off of GYP, but we don't have
> one
> yet.
>
> https://codereview.chromium.org/1475173002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-11-26 00:51:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-26 00:52:36]

Description was changed from

==========
Fix downloading of LLVM Gold plugin for the official Chrome.

The build needs the plugin to make an LTO build, which will soon
be the default for the official Chrome as a part of
Control Flow Integrity launch. See
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-i...
for more details.

BUG=chromium:464797
==========

to

==========
Fix downloading of LLVM Gold plugin for the official Chrome.

The build needs the plugin to make an LTO build, which will soon
be the default for the official Chrome as a part of
Control Flow Integrity launch. See
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-i...
for more details.

BUG=chromium:464797

Committed: https://crrev.com/9ddd19577633e02c8c6f6ae83ee5efd9e2c4c567
Cr-Commit-Position: refs/heads/master@{#361774}
==========

[commit-bot: I haz the power, 2015-11-26 00:52:36]

Patchset 1 (id:??) landed as
https://crrev.com/9ddd19577633e02c8c6f6ae83ee5efd9e2c4c567
Cr-Commit-Position: refs/heads/master@{#361774}