Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1475113004: Fix shutdown assert in new Mojo EDK. (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix shutdown assert in new Mojo EDK. The problem was that on IO thread shutdown there could be a pending task to call CloseOnIO. The deletion of this pending task can free the last reference to MessagePipeDispatcher (or other dispatchers) that are holding on to a RawChannel. The destructor would then assert because channel_ was alive. The fix is to detect this case and destruct the channel, since it's safe as we're on the IO thread. I only saw this when running with --v8-pac-mojo-out-of-process. BUG=561803 Committed: https://crrev.com/8c4d270033fcce330ccb80350446125692c8e0c4 Cr-Commit-Position: refs/heads/master@{#362161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 4 chunks +12 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jam
5 years ago (2015-11-30 16:13:48 UTC) #3
yzshen1
lgtm
5 years ago (2015-11-30 17:02:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475113004/1
5 years ago (2015-11-30 17:04:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 18:16:10 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-30 18:17:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c4d270033fcce330ccb80350446125692c8e0c4
Cr-Commit-Position: refs/heads/master@{#362161}

Powered by Google App Engine
This is Rietveld 408576698