[Refinery] Introduce TypePropagatorAnalyzer - pointer types.

syzygy/refinery/symbols/symbol_provider.h

 // Copyright 2015 Google Inc. All Rights Reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 14 matching lines @@
 #include "syzygy/refinery/symbols/simple_cache.h"
 #include "syzygy/refinery/types/type_repository.h"
 
 namespace refinery {
 
 // Fwd.
 class ProcessState;
 
 // The SymbolProvider provides symbol information. See DiaSymbolProvider for an
 // alternative.
+// TODO(manzagop): get rid of the functions that take in a process state. The
+// symbol provider shouldn't offer that service.
 class SymbolProvider : public base::RefCounted<SymbolProvider> {
  public:
   SymbolProvider();
-  ~SymbolProvider();
+  // @note virtual to enable mocking.
+  virtual ~SymbolProvider();
 
   // Retrieves or creates a TypeRepository for the module within @p
   // process_state corresponding to @p va.
   // @param va virtual address within a module for which to get a
   //     TypeRepository.
   // @param process_state the process state within which to interpret @p va.
   // @param type_repo on success, returns a type repository for the module. On
   //     failure, contains nullptr.
   // @returns true on success, false on failure.
   bool FindOrCreateTypeRepository(const Address va,
                                   ProcessState* process_state,
                                   scoped_refptr<TypeRepository>* type_repo);
 
   // Retrieves or creates a TypeRepository for the module  corresponding to @p
   // signature.
+  // @note virtual to enable mocking.
   // @param signature the signature of the module for which to get a type
   //     repository.
   // @param type_repo on success, returns a type repository for the module. On
   //     failure, contains nullptr.
   // @returns true on success, false on failure.
-  bool FindOrCreateTypeRepository(const pe::PEFile::Signature& signature,
-                                  scoped_refptr<TypeRepository>* type_repo);
+  virtual bool FindOrCreateTypeRepository(
+      const pe::PEFile::Signature& signature,
+      scoped_refptr<TypeRepository>* type_repo);
 
   // Retrieves or creates a TypeNameIndex for the module within @p
   // process_state corresponding to @p va.
   // @param va virtual address within a module for which to get a
   //     TypeRepository.
   // @param process_state the process state within which to interpret @p va.
   // @param type_repo on success, returns a typename index for the module. On
   //     failure, contains nullptr.
   // @returns true on success, false on failure.
   bool FindOrCreateTypeNameIndex(const Address va,
@@ skipping 28 matching lines @@
   // form of null pointers.
   SimpleCache<TypeRepository> type_repos_;
   SimpleCache<TypeNameIndex> typename_indices_;
 
   DISALLOW_COPY_AND_ASSIGN(SymbolProvider);
 };
 
 }  // namespace refinery
 
 #endif  // SYZYGY_REFINERY_SYMBOLS_SYMBOL_PROVIDER_H_