Retry more errors when talking to Rietveld

rietveld.py

 # coding: utf-8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines class Rietveld to easily access a rietveld instance.
 
 Security implications:
 
 The following hypothesis are made:
 - Rietveld enforces:
@@ skipping 415 matching lines @@
           flake_codes = [500, 502, 503]
           if retry_on_404:
             flake_codes.append(404)
           if e.code not in flake_codes:
             raise
         except urllib2.URLError, e:
           if retry >= (self._maxtries - 1):
             raise
           if (not 'Name or service not known' in e.reason and
               not 'EOF occurred in violation of protocol' in e.reason and
+              not 'Connection timed out' in e.reason and
+              not 'The handshake operation timed out' in e.reason and
               # On windows we hit weird bug http://crbug.com/537417
               # with message '[Errno 10060] A connection attempt failed...'
               not (sys.platform.startswith('win') and
                    isinstance(e.reason, socket.error) and
                    e.reason.errno == errno.ETIMEDOUT
                 )
               ):
             # Usually internal GAE flakiness.
             raise
         except socket.error, e:
           if retry >= (self._maxtries - 1):
             raise
           if not 'timed out' in str(e):

[tandrii(chromium), 2015/11/25 16:56:37]

this was probably the hope originally.

[Sergiy Byelozyorov, 2015/11/25 17:02:54]

Acknowledged.

             raise
         # If reaching this line, loop again. Uses a small backoff.
         time.sleep(min(10, 1+retry*2))
     except urllib2.HTTPError as e:
       print 'Request to %s failed: %s' % (e.geturl(), e.read())
       raise
     finally:
       upload.ErrorExit = old_error_exit
 
   # DEPRECATED.
@@ skipping 271 matching lines @@
       self, issue, patchset, reason, clobber, revision, builders_and_tests,
       master=None, category='cq'):
     logging.info('ReadOnlyRietveld: triggering try jobs %r for issue %d' %
         (builders_and_tests, issue))
 
   def trigger_distributed_try_jobs(  # pylint:disable=R0201
       self, issue, patchset, reason, clobber, revision, masters,
       category='cq'):
     logging.info('ReadOnlyRietveld: triggering try jobs %r for issue %d' %
         (masters, issue))