Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1475043003: X87: [interpreter] Switch passing of new.target to register. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [interpreter] Switch passing of new.target to register. port 3d004eeab23c8b47bd9bdd2cc66434dcc19a1b2f (r32264) original commit message: This passes the new.target value in a register instead of through a side-channel via the construct stub. The interpreter entry trampoline stores this value in a bytecode register so that it can be accessed directly by the interpreter. The size of the interpreter stack frame hence grows by one slot. BUG= Committed: https://crrev.com/4334a81823d299c1465b1a7396fa3df4f3b2c488 Cr-Commit-Position: refs/heads/master@{#32309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
5 years ago (2015-11-26 02:43:06 UTC) #2
Weiliang
lgtm
5 years ago (2015-11-26 02:50:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475043003/1
5 years ago (2015-11-26 02:50:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 03:14:26 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4334a81823d299c1465b1a7396fa3df4f3b2c488 Cr-Commit-Position: refs/heads/master@{#32309}
5 years ago (2015-11-26 03:15:03 UTC) #8
Michael Starzinger
5 years ago (2015-11-26 08:43:22 UTC) #9
Message was sent while issue was closed.
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698