Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: snapshot/win/process_snapshot_win.h

Issue 1475033005: win: Only capture the loader lock for now (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/win/end_to_end_test.py ('k') | snapshot/win/process_snapshot_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/process_snapshot_win.h
diff --git a/snapshot/win/process_snapshot_win.h b/snapshot/win/process_snapshot_win.h
index a7238fd7a34ebdeb0ece78182e338af1807f25fc..a1dd72334d6e28e3e00d5898d6084009ca7cd3a1 100644
--- a/snapshot/win/process_snapshot_win.h
+++ b/snapshot/win/process_snapshot_win.h
@@ -168,13 +168,11 @@ class ProcessSnapshotWin final : public ProcessSnapshot {
WinVMSize DetermineSizeOfEnvironmentBlock(
WinVMAddress start_of_environment_block);
- // Starting from the address of a CRITICAL_SECTION, walks the doubly-linked
- // list stored in RTL_CRITICAL_SECTION.DebugInfo.ProcessLocksList adding both
- // the RTL_CRITICAL_SECTION and the RTL_CRITICAL_SECTION_DEBUG memory blocks
- // to the snapshot.
+ // Starting from the address of a CRITICAL_SECTION, add a lock and, if valid,
+ // its .DebugInfo field to the snapshot.
template <class Traits>
- void ReadLocks(WinVMAddress start,
- PointerVector<internal::MemorySnapshotWin>* into);
+ void ReadLock(WinVMAddress start,
+ PointerVector<internal::MemorySnapshotWin>* into);
internal::SystemSnapshotWin system_;
PointerVector<internal::MemorySnapshotWin> extra_memory_;
« no previous file with comments | « snapshot/win/end_to_end_test.py ('k') | snapshot/win/process_snapshot_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698