Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Issue 1475033003: Unconditionally expand STATIC_ASSERT to the C++11 form. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unconditionally expand STATIC_ASSERT to the C++11 form. Also add a note that it should go away over time. BUG=none LOG=n Committed: https://crrev.com/b60d17eccde74db90148cf7e5a74be28fcaa7773 Cr-Commit-Position: refs/heads/master@{#32290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M include/v8config.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/base/macros.h View 1 chunk +1 line, -25 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Nico
5 years ago (2015-11-25 16:13:01 UTC) #2
jochen (gone - plz use gerrit)
On 2015/11/25 at 16:13:01, thakis wrote: > why not just search/replace?
5 years ago (2015-11-25 16:20:27 UTC) #3
Nico
On 2015/11/25 16:20:27, jochen wrote: > On 2015/11/25 at 16:13:01, thakis wrote: > > > ...
5 years ago (2015-11-25 16:33:13 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-11-25 16:34:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475033003/1
5 years ago (2015-11-25 16:36:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 17:16:13 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-25 17:16:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b60d17eccde74db90148cf7e5a74be28fcaa7773
Cr-Commit-Position: refs/heads/master@{#32290}

Powered by Google App Engine
This is Rietveld 408576698