Get module versions and types from in-memory images

util/win/module_version.h

Index: util/win/module_version.h
diff --git a/util/win/module_version.h b/util/win/module_version.h
index be56eb9df9a2785c257b8880bee1c3a6509f4b10..b807b9332869e444cea52d34e54782d41949f3d4 100644
--- a/util/win/module_version.h
+++ b/util/win/module_version.h
@@ -24,9 +24,15 @@ namespace crashpad {
 //! \brief Retrieve the type and version information from a given module (exe,
 //!     dll, etc.)
 //!
+//! This function calls `GetFileVersionInfo()`, which can implicitly call

[scottmg, 2015/11/26 21:30:00]

This is just here for system_snapshot_win.cc now? We should switch that to
GetModuleHandle("kernel32.dll") and the new code and delete this entirely.

... Oh, the test too. Maybe it'd be better to move it into the test file or
test/ somewhere.

[Mark Mentovai, 2015/12/01 18:48:01]

scottmg wrote:
I started going down this road, but then I stopped when I needed to call
GetModuleInformation() to get the MODULEINFO, which brings in psapi.dll. psapi
seems a little weird, and we only use it in a test now. Is it desirable in
non-test code?

[scottmg, 2015/12/01 19:43:01]

Hmm, right, forgot about that. Seems like we should be able to avoid needing to
do that.

But in any case, since we're only using it for kernel32 it's fine to keep using
it, and make sure to heed the warning here in the future.

+//! `LoadLibrary()` to load \a path into the calling process. Do not call this
+//! function on an untrusted module, because there is a risk of executing the
+//! module’s code.
+//!
 //! \param[in] path The path to the module to be inspected.
-//! \param[out] vs_fixedfileinfo The `VS_FIXEDFILEINFO` on success.
-//!    `dwFileFlags`  will have been masked with `dwFileFlagsMask` already.
+//! \param[out] vs_fixedfileinfo The VS_FIXEDFILEINFO on success.
+//!    VS_FIXEDFILEINFO::dwFileFlags will have been masked with
+//!    VS_FIXEDFILEINFO::dwFileFlagsMask already.
 //!
 //! \return `true` on success, or `false` on failure with a message logged. If
 //!     the module has no `VERSIONINFO` resource, `false` will be returned