Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1475023003: Merge to XFA: Suppress invalid-heap-arg error in pdfium_unittests (Closed)

Created:
5 years ago by zhaoqin1
Modified:
5 years ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Suppress invalid-heap-arg error in pdfium_unittests Visual Studio sometimes uses new instead of new[] for array allocation, which causes Dr. Memory report invalid-heap-arg errors. Suppress such errors since it is not developers' problems. TBR=tsepez@chromium.org BUG=pdfium:287 Review URL: https://codereview.chromium.org/1473913002 . (cherry picked from commit 1fb4bc47e216c9caebdf7bc8479d45285ee7693b) Committed: https://pdfium.googlesource.com/pdfium/+/e77fc688dde137da9e91dce9bf7326541b5e19c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/drmemory/suppressions.txt View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
zhaoqin1
Committed patchset #1 (id:1) manually as e77fc688dde137da9e91dce9bf7326541b5e19c1 (presubmit successful).
5 years ago (2015-11-25 18:23:49 UTC) #2
Tom Sepez
5 years ago (2015-11-25 18:37:53 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698