NaCl: enable meta-based validation for shared libraries.

chrome/common/nacl_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines messages between the browser and NaCl process.
 
 // Multiply-included message file, no traditional include guard.
 #include "base/process.h"
 #include "chrome/common/nacl_types.h"
 #include "ipc/ipc_channel_handle.h"
 #include "ipc/ipc_message_macros.h"
+#include "ipc/ipc_platform_file.h"
 
 #define IPC_MESSAGE_START NaClMsgStart
 
 IPC_STRUCT_TRAITS_BEGIN(nacl::NaClStartParams)
   IPC_STRUCT_TRAITS_MEMBER(handles)
   IPC_STRUCT_TRAITS_MEMBER(debug_stub_server_bound_socket)
   IPC_STRUCT_TRAITS_MEMBER(validation_cache_enabled)
   IPC_STRUCT_TRAITS_MEMBER(validation_cache_key)
   IPC_STRUCT_TRAITS_MEMBER(version)
   IPC_STRUCT_TRAITS_MEMBER(enable_exception_handling)
@@ skipping 49 matching lines @@
 // contains the signatures of previously validated code chunks.
 IPC_SYNC_MESSAGE_CONTROL1_1(NaClProcessMsg_QueryKnownToValidate,
                             std::string, /* A validation signature */
                             bool /* Can validation be skipped? */)
 
 // Used by the NaCl process to add a validation signature to the validation
 // database in the browser.
 IPC_MESSAGE_CONTROL1(NaClProcessMsg_SetKnownToValidate,
                      std::string /* A validation signature */)
 
+// Used by the NaCl process to aquire trusted information about a file directly

[Mark Seaborn, 2013/05/24 20:21:58]

"acquire"

[Nick Bray (chromium), 2013/05/24 21:35:24]

Done.

+// from the browser, including the file's path as well as a fresh version of the
+// file handle.
+IPC_SYNC_MESSAGE_CONTROL2_2(NaClProcessMsg_ResolveFileToken,

[Mark Seaborn, 2013/05/24 20:21:58]

"Resolve" is vague.  How about "OpenFileFromToken" or "OpenFileGivenToken"?

(I know you already used the term "Resolve" in the NaCl code, but I still think
it would be better to use "Open" here.)

[Nick Bray (chromium), 2013/05/24 21:35:24]

Opening is only part of the elephant.  I don't think "Open" is the right verb. 
"Given" is also an awkward way to resolve the resulting ambiguity.  Leaving as
is.

+                            uint64, /* file_token_lo */
+                            uint64, /* file_token_hi */
+                            IPC::PlatformFileForTransit, /* fd */
+                            base::FilePath /* Path opened to get fd */)
+
 // Notify the browser process that the server side of the PPAPI channel was
 // created successfully.
 IPC_MESSAGE_CONTROL1(NaClProcessHostMsg_PpapiChannelCreated,
                      IPC::ChannelHandle /* channel_handle */)