Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1474993002: Add vabr to chrome/renderer/autofill/OWNERS (Closed)

Created:
5 years ago by vabr (Chromium)
Modified:
5 years ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, bondd+autofillwatch_chromium.org, jdonnelly+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add vabr to chrome/renderer/autofill/OWNERS vabr is already in //components/autofill/OWNERS and has owned the passwords-related files here. The rest of the chrome/renderer/autofill/ directory are just browsertests for the autofill code vabr already owns. BUG=None Committed: https://crrev.com/f5e5012ab6a7826b6bfddb267ae0ab1a8a03f2da Cr-Commit-Position: refs/heads/master@{#361744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/renderer/autofill/OWNERS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
vabr (Chromium)
Evan, Ilya, Could you consider approving this change? If not, then at least please take ...
5 years ago (2015-11-25 09:30:08 UTC) #3
vabr (Chromium)
Evan, Ilya, Could you consider approving this change? If not, then at least please take ...
5 years ago (2015-11-25 09:30:08 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474993002/1
5 years ago (2015-11-25 09:30:38 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 09:41:15 UTC) #8
Evan Stade
lgtm
5 years ago (2015-11-25 19:41:20 UTC) #9
Ilya Sherman
lgtm
5 years ago (2015-11-25 21:43:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474993002/1
5 years ago (2015-11-25 21:43:43 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 22:09:24 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-25 22:10:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5e5012ab6a7826b6bfddb267ae0ab1a8a03f2da
Cr-Commit-Position: refs/heads/master@{#361744}

Powered by Google App Engine
This is Rietveld 408576698