Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1474983004: Mute non-CORS cross origin promise rejection events (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mute non-CORS cross origin promise rejection events BUG=495801 R=domenic@chromium.org,haraken@chromium.org,yangguo@chromium.org Committed: https://crrev.com/07cffb9ff140185613a3c8721c945420e09ad69a Cr-Commit-Position: refs/heads/master@{#361986}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Messages

Total messages: 17 (6 generated)
jochen (gone - plz use gerrit)
ptal depends on the next v8 roll, so no tryjobs yet https://codereview.chromium.org/1474983004/diff/1/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (left): ...
5 years ago (2015-11-26 13:06:06 UTC) #1
Yang
On 2015/11/26 13:06:06, jochen wrote: > ptal > > depends on the next v8 roll, ...
5 years ago (2015-11-26 13:19:03 UTC) #2
haraken
LGTM
5 years ago (2015-11-26 14:02:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474983004/1
5 years ago (2015-11-26 22:43:08 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/146853)
5 years ago (2015-11-27 00:26:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474983004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474983004/20001
5 years ago (2015-11-27 12:38:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 12:43:13 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/07cffb9ff140185613a3c8721c945420e09ad69a Cr-Commit-Position: refs/heads/master@{#361986}
5 years ago (2015-11-27 12:44:13 UTC) #13
Michael Achenbach
API stability nag (no action required): https://build.chromium.org/p/chromium.fyi/builders/Linux%20V8%20API%20Stability/builds/9051/
5 years ago (2015-11-27 14:26:30 UTC) #15
jochen (gone - plz use gerrit)
meh, I landed the API yesterday, it rolled into chromium yesterday... I thought waiting until ...
5 years ago (2015-11-27 14:28:07 UTC) #16
Michael Achenbach
5 years ago (2015-11-27 14:30:01 UTC) #17
Message was sent while issue was closed.
On 2015/11/27 14:28:07, jochen wrote:
> meh, I landed the API yesterday, it rolled into chromium yesterday... I
thought
> waiting until today was good enough

Not in terms of canaries. If v8 gets reverted on the canary to the last canary
version it'll break the build (but only if).

Powered by Google App Engine
This is Rietveld 408576698