Support for client certs in ssl_server_socket.

net/ssl/openssl_ssl_util.h

Index: net/ssl/openssl_ssl_util.h
diff --git a/net/ssl/openssl_ssl_util.h b/net/ssl/openssl_ssl_util.h
index af8b9abb15b9f4f8b026dc6afca35c0d2285db48..f0cefb863ac3634d360a39308bd958d49fda5509 100644
--- a/net/ssl/openssl_ssl_util.h
+++ b/net/ssl/openssl_ssl_util.h
@@ -7,7 +7,11 @@
 
 #include <stdint.h>
 
+#include <openssl/ssl.h>
+
+#include "net/cert/x509_certificate.h"
 #include "net/log/net_log.h"
+#include "net/ssl/scoped_openssl_types.h"
 
 namespace crypto {
 class OpenSSLErrStackTracer;
@@ -69,6 +73,18 @@ NetLog::ParametersCallback CreateNetLogOpenSSLErrorCallback(
     int ssl_error,
     const OpenSSLErrorInfo& error_info);
 
+void FreeX509Stack(STACK_OF(X509)* ptr);
+void FreeX509NameStack(STACK_OF(X509_NAME)* ptr);

[davidben, 2016/01/25 20:56:11]

Why is this declared both here and in scoped_openssl_types.h?

[ryanchung, 2016/01/29 23:22:14]

Hmm, I should remove it from here.
scoped_openssl_types.h needs to know about the Free functions in
openssl_ssl_util.cc but it would create a circular dependancy if I just included
openssl_ssl_util.h in scoped_openssl_types.h

But then now they'll be declared in scoped_openssl_types.h while being defined
in openssl_ssl_util.cc
What would you suggest?

[davidben, 2016/02/04 00:40:11]

Hrm. I'd probably either add scoped_openssl_types.cc or maybe just define it in
the header as an inline function. As functions go, they're pretty tiny.

[ryanchung, 2016/02/05 01:56:13]

Done. Inlined.

+
+// Returns the net SSL version number (see ssl_connection_status_flags.h) for
+// this SSL connection.
+int GetNetSSLVersion(SSL* ssl);
+
+ScopedX509 OSCertHandleToOpenSSL(X509Certificate::OSCertHandle os_handle);
+
+ScopedX509_STACK OSCertHandlesToOpenSSL(
+    const X509Certificate::OSCertHandles& os_handles);
+
 }  // namespace net
 
 #endif  // NET_SSL_OPENSSL_SSL_UTIL_H_