Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1474973002: Remove WebElementDescriptor (Closed)

Created:
5 years ago by vabr (Chromium)
Modified:
5 years ago
Reviewers:
Mathieu, Mike West
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, estade+watch_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebElementDescriptor This is unused code, this CL removes it. There is still a piece in the browsertest, which uses the removed struct for convenience in some testcases. That usage has been kept, but the struct has been moved in the anonymous namespace there. R=mkwst@chromium.org BUG=556433 Committed: https://crrev.com/f9a5547deb119114e56fca163a13a03f50a7a9ab Cr-Commit-Position: refs/heads/master@{#361849}

Patch Set 1 #

Patch Set 2 : Fix BUILD files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -96 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 2 chunks +14 lines, -1 line 0 comments Download
M components/autofill.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/content/common/autofill_messages.h View 2 chunks +0 lines, -9 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/form_autofill_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_xml_parser.h View 1 chunk +0 lines, -8 lines 0 comments Download
M components/autofill/core/browser/autofill_xml_parser.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M components/autofill/core/browser/form_structure.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/common/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D components/autofill/core/common/web_element_descriptor.h View 1 chunk +0 lines, -31 lines 0 comments Download
D components/autofill/core/common/web_element_descriptor.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
vabr (Chromium)
Hi Mike, PTAL at this destructive CL! Cheers, Vaclav
5 years ago (2015-11-25 09:20:28 UTC) #1
Mike West
Deleting IPC LGTM.
5 years ago (2015-11-25 14:59:30 UTC) #2
vabr (Chromium)
Thanks, Mike. @mathp: Could you please review the rest (the CL without IPCs)? Cheers, Vaclav
5 years ago (2015-11-25 15:39:42 UTC) #4
Mathieu
On 2015/11/25 15:39:42, vabr (Chromium) wrote: > Thanks, Mike. > > @mathp: Could you please ...
5 years ago (2015-11-25 16:26:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474973002/20001
5 years ago (2015-11-26 08:16:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 08:53:58 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-26 08:55:26 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9a5547deb119114e56fca163a13a03f50a7a9ab
Cr-Commit-Position: refs/heads/master@{#361849}

Powered by Google App Engine
This is Rietveld 408576698