Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1474943005: Revert of [debugger] flood function for stepping before calling it. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] flood function for stepping before calling it. (patchset #7 id:120001 of https://codereview.chromium.org/1463803002/ ) Reason for revert: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3074 Original issue's description: > [debugger] flood function for stepping before calling it. > > R=verwaest@chromium.org > > Committed: https://crrev.com/93eb633214e0f97bf70ae30d2a07b7fbbaa78266 > Cr-Commit-Position: refs/heads/master@{#32285} TBR=verwaest@chromium.org,mstarzinger@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/df3dee87a7a86dfba3981627a1eb5e462a108a63 Cr-Commit-Position: refs/heads/master@{#32299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+524 lines, -760 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +6 lines, -8 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 4 chunks +21 lines, -67 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +6 lines, -7 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 6 chunks +21 lines, -62 lines 0 comments Download
M src/assembler.h View 3 chunks +2 lines, -15 lines 0 comments Download
M src/assembler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/debug/debug.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 31 chunks +235 lines, -96 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 6 chunks +25 lines, -61 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/js/array.js View 7 chunks +21 lines, -0 lines 0 comments Download
M src/js/collection.js View 2 chunks +4 lines, -0 lines 0 comments Download
M src/js/macros.py View 1 chunk +1 line, -0 lines 0 comments Download
M src/js/promise.js View 3 chunks +4 lines, -2 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +6 lines, -9 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 4 chunks +21 lines, -68 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 2 chunks +6 lines, -8 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 4 chunks +20 lines, -66 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +45 lines, -6 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 3 chunks +10 lines, -8 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 5 chunks +27 lines, -65 lines 0 comments Download
M test/cctest/test-debug.cc View 6 chunks +1 line, -9 lines 0 comments Download
D test/mjsunit/debug-step-into-json.js View 1 chunk +0 lines, -35 lines 0 comments Download
D test/mjsunit/debug-step-into-valueof.js View 1 chunk +0 lines, -35 lines 0 comments Download
D test/mjsunit/debug-stepin-builtin-callback-opt.js View 1 chunk +0 lines, -36 lines 0 comments Download
D test/mjsunit/es6/debug-step-into-regexp-subclass.js View 1 chunk +0 lines, -36 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-401915.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [debugger] flood function for stepping before calling it.
5 years ago (2015-11-25 19:24:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474943005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474943005/1
5 years ago (2015-11-25 19:24:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 19:26:16 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-25 19:26:57 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/df3dee87a7a86dfba3981627a1eb5e462a108a63
Cr-Commit-Position: refs/heads/master@{#32299}

Powered by Google App Engine
This is Rietveld 408576698