Roll Clang 247874:254049

tools/clang/scripts/update.sh

 #!/usr/bin/env bash
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script will check out llvm and clang into third_party/llvm and build it.
 
 # Do NOT CHANGE this if you don't know what you're doing -- see
 # https://code.google.com/p/chromium/wiki/UpdatingClang
 # Reverting problematic clang rolls is safe, though.
-CLANG_REVISION=247874
+CLANG_REVISION=254049
 
 # This is incremented when pushing a new build of Clang at the same revision.
 CLANG_SUB_REVISION=1
 
 PACKAGE_VERSION="${CLANG_REVISION}-${CLANG_SUB_REVISION}"
 
 THIS_DIR="$(dirname "${0}")"
 LLVM_DIR="${THIS_DIR}/../../../third_party/llvm"
 LLVM_BUILD_DIR="${LLVM_DIR}/../llvm-build/Release+Asserts"
 COMPILER_RT_BUILD_DIR="${LLVM_DIR}/../llvm-build/compiler-rt"
@@ skipping 503 matching lines @@
 fi
 
 
 # If building at head, define a macro that plugins can use for #ifdefing
 # out code that builds at head, but not at CLANG_REVISION or vice versa.
 if [[ -n ${LLVM_FORCE_HEAD_REVISION:-''} ]]; then
   CFLAGS="${CFLAGS} -DLLVM_FORCE_HEAD_REVISION"
   CXXFLAGS="${CXXFLAGS} -DLLVM_FORCE_HEAD_REVISION"
 fi
 
+# Pin MSan to the old ABI.
+# TODO: revert this when instrumented libraries can be rebuilt with the new ABI.

[Nico, 2015/11/25 15:26:02]

eugenis already filed a tracking bug for this that this should poitn to

[hans, 2015/11/25 17:55:13]

Done.

+CXXFLAGS="${CXXFLAGS} -DMSAN_LINUX_X86_64_OLD_MAPPING"
+
 # Hook the Chromium tools into the LLVM build. Several Chromium tools have
 # dependencies on LLVM/Clang libraries. The LLVM build detects implicit tools
 # in the tools subdirectory, so install a shim CMakeLists.txt that forwards to
 # the real directory for the Chromium tools.
 # Note that the shim directory name intentionally has no _ or _. The implicit
 # tool detection logic munges them in a weird way.
 mkdir -v ${CHROME_TOOLS_SHIM_DIR}
 cat > ${CHROME_TOOLS_SHIM_DIR}/CMakeLists.txt << EOF
 # Since tools/clang isn't actually a subdirectory, use the two argument version
 # to specify where build artifacts go. CMake doesn't allow reusing the same
@@ skipping 43 matching lines @@
 strip ${STRIP_FLAGS} bin/clang
 popd
 
 # Build compiler-rt out-of-tree.
 # Do a clobbered build due to cmake changes.
 rm -rf "${COMPILER_RT_BUILD_DIR}"
 mkdir -p "${COMPILER_RT_BUILD_DIR}"
 pushd "${COMPILER_RT_BUILD_DIR}"
 
 rm -fv CMakeCache.txt
-MACOSX_DEPLOYMENT_TARGET=${deployment_target} CC="" CXX="" cmake -GNinja \
+if [[ -z "${bootstrap}" ]]; then
+  # compiler_rt doesn't build with Xcode 6's clang, but not all bots have
+  # Xcode 7 yet.  So use the just-built clang for building compiler-rt.
+  # However, in bootstrap builds, we delete libc++ to work around PR24068 -- so
+  # compiler_rt's CMake checks can't find <iostream> and decide that no arch
+  # is supported.  So use the installed bootstrap compiler in bootstrap builds,
+  # it has the libc++ headers installed (CXX is already set to that in
+  # bootstrap builds).
+  CC="${ABS_LLVM_BUILD_DIR}/bin/clang"
+  CXX="${ABS_LLVM_BUILD_DIR}/bin/clang++"
+elif [[ "${OS}" = "Darwin" ]]; then
+  # ...except that compiler-rt currently doesn't build with the bootstrap
+  # compiler on Darwin either! So use the system compiler there.
+  # TOOD(thakis): Remove this once http://llvm.org/PR25465 is fixed.
+  CC=cc
+  CXX=c++
+fi
+
+# Pin MSan to the old ABI.
+COMPILER_RT_CXXFLAGS="-DMSAN_LINUX_X86_64_OLD_MAPPING"
+
+MACOSX_DEPLOYMENT_TARGET=${deployment_target} cmake -GNinja \
     -DCMAKE_BUILD_TYPE=Release \
     -DLLVM_ENABLE_ASSERTIONS=ON \
     -DLLVM_ENABLE_THREADS=OFF \
-    -DCMAKE_C_COMPILER="${ABS_LLVM_BUILD_DIR}/bin/clang" \
-    -DCMAKE_CXX_COMPILER="${ABS_LLVM_BUILD_DIR}/bin/clang++" \
+    -DCMAKE_C_COMPILER="${CC}" \
+    -DCMAKE_CXX_COMPILER="${CXX}" \
+    -DCMAKE_CXX_FLAGS="${COMPILER_RT_CXXFLAGS}" \
     -DSANITIZER_MIN_OSX_VERSION="10.7" \
     -DLLVM_CONFIG_PATH="${ABS_LLVM_BUILD_DIR}/bin/llvm-config" \
     "${ABS_COMPILER_RT_DIR}"
 
 ninja
 
 # Copy selected output to the main tree.
 # Darwin doesn't support cp --parents, so pipe through tar instead.
 CLANG_VERSION=$("${ABS_LLVM_BUILD_DIR}/bin/clang" --version | \
      sed -ne 's/clang version \([0-9]\.[0-9]\.[0-9]\).*/\1/p')
@@ skipping 65 matching lines @@
   # Run Chrome tool tests.
   ninja -C "${LLVM_BUILD_DIR}" cr-check-all
 fi
 if [[ -n "$run_tests" ]]; then
   # Run the LLVM and Clang tests.
   ninja -C "${LLVM_BUILD_DIR}" check-all
 fi
 
 # After everything is done, log success for this revision.
 echo "${PACKAGE_VERSION}" > "${STAMP_FILE}"