Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 14749006: [WIP] Pretend-to-preconnect for {mouse,touch}-event triggers.

Created:
7 years, 7 months ago by kouhei (in TOK)
Modified:
6 years, 8 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@preconnect-pretend
Visibility:
Public.

Description

Pretend-to-preconnect for {mouse,touch}-event triggers. This is to simulate precision of {mouse,touch}-event based preconnect triggers without preconnecting for real. BUG=235361

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -16 lines) Patch
M net/http/http_request_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +37 lines, -13 lines 1 comment Download
M net/socket/client_socket_pool_manager.h View 1 chunk +17 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_manager.cc View 9 chunks +53 lines, -3 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
kouhei (in TOK)
I think this patch can be made simpler with the refactoring patch: https://codereview.chromium.org/14471023/
7 years, 7 months ago (2013-05-01 08:11:11 UTC) #1
mmenke
Know you haven't sent this out for review, but what are you hoping to learn ...
7 years, 7 months ago (2013-05-01 16:55:08 UTC) #2
kouhei (in TOK)
Thank you for your comments. I will try what it would look like with a ...
7 years, 7 months ago (2013-05-02 10:55:59 UTC) #3
mmenke
On 2013/05/02 10:55:59, Kouhei_UENO wrote: > Thank you for your comments. > > I will ...
7 years, 7 months ago (2013-05-02 14:57:58 UTC) #4
mmenke
On 2013/05/02 14:57:58, mmenke wrote: > On 2013/05/02 10:55:59, Kouhei_UENO wrote: > > Thank you ...
7 years, 7 months ago (2013-05-02 14:59:50 UTC) #5
kouhei (in TOK)
+cbentzel, tburkard Can I ask for your comments? I want to measure how each mouse/gesture ...
7 years, 7 months ago (2013-05-07 01:45:41 UTC) #6
mmenke
On 2013/05/07 01:45:41, Kouhei_UENO wrote: > +cbentzel, tburkard > > Can I ask for your ...
7 years, 7 months ago (2013-05-07 02:36:18 UTC) #7
kouhei (in TOK)
> Doing sufficient instrumentation to get meaningful numbers here seems like it > would be ...
7 years, 7 months ago (2013-05-08 01:54:35 UTC) #8
cbentzel
On 2013/05/08 01:54:35, Kouhei_UENO wrote: > > Doing sufficient instrumentation to get meaningful numbers here ...
7 years, 7 months ago (2013-05-10 10:16:59 UTC) #9
kouhei (in TOK)
7 years, 7 months ago (2013-05-13 01:34:06 UTC) #10
> I'm OK with actually doing preconnects in a Finch trial if it simplifies
> collection, as the downside is reasonably small.

Thanks for your reply.

I will start with the Finch trial after preconnect interface discussions are
done: https://codereview.chromium.org/14746002

Powered by Google App Engine
This is Rietveld 408576698