Subzero. ARM32. Pre-lowers calls to ARM32 Helpers.

src/IceTargetLoweringARM32.h

Index: src/IceTargetLoweringARM32.h
diff --git a/src/IceTargetLoweringARM32.h b/src/IceTargetLoweringARM32.h
index e3bebde0ed998e32a5e31493e231890117834827..81b63a86abe5803bad1128e82871c5fab1d83057 100644
--- a/src/IceTargetLoweringARM32.h
+++ b/src/IceTargetLoweringARM32.h
@@ -237,7 +237,7 @@ protected:
   void lowerUnreachable(const InstUnreachable *Inst) override;
   void prelowerPhis() override;
   uint32_t getCallStackArgumentsSizeBytes(const InstCall *Instr) override;
-  void genTargetHelperCallFor(Inst *Instr) override { (void)Instr; }
+  void genTargetHelperCallFor(Inst *Instr) override;
   void doAddressOptLoad() override;
   void doAddressOptStore() override;
   void randomlyInsertNop(float Probability,
@@ -268,8 +268,7 @@ protected:
   using DivInstr = void (TargetARM32::*)(Variable *, Variable *, Variable *,
                                          CondARM32::Cond);
   void lowerIDivRem(Variable *Dest, Variable *T, Variable *Src0R, Operand *Src1,
-                    ExtInstr ExtFunc, DivInstr DivFunc,
-                    const char *DivHelperName, bool IsRemainder);
+                    ExtInstr ExtFunc, DivInstr DivFunc, bool IsRemainder);
 
   void lowerCLZ(Variable *Dest, Variable *ValLo, Variable *ValHi);
 
@@ -917,6 +916,13 @@ private:
   OperandARM32Mem *formAddressingMode(Type Ty, Cfg *Func, const Inst *LdSt,
                                       Operand *Base);
 
+  void Ctpop64Postamble(const InstCall *Instr);

[Jim Stichnoth, 2015/11/30 21:47:20]

Start function names with a lowercase letter, per LLVM convention.

[John, 2015/11/30 22:16:25]

Done.

+  void DivRemPreamble(const InstCall *Instr);
+  std::unordered_map<Operand *, void (TargetARM32::*)(const InstCall *Inst)>
+      ARM32HelpersPreamble;

[Jim Stichnoth, 2015/11/30 21:47:20]

The prefix "ARM32" seems redundant with this being part of an ARM32 class.

[John, 2015/11/30 22:16:25]

I agree. Previously I had HelpersPreamble/HelpersPostamble (without the ARM32),
but that was an eye sore. Those names don't really convey any decent
information. Not that ARM32Helpers* is any better, but I could not think of
anything better.

[Jim Stichnoth, 2015/12/01 17:01:56]

Acknowledged.

+  std::unordered_map<Operand *, void (TargetARM32::*)(const InstCall *Inst)>
+      ARM32HelpersPostamble;
+
   class BoolComputationTracker {
   public:
     BoolComputationTracker() = default;