Add alpha argument to glResizeCHROMIUM

Add alpha argument to glResizeCHROMIUM

This lets the compositor specify whether the backbuffer will need to be blended with the contents behind it, and if not it can use a method that uses less power.

BUG=561185
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8046f1cbb18126cd9ea1a405c93e545f2c377978
Cr-Commit-Position: refs/heads/master@{#362817}

[jbauman, 2015-12-01 22:51:53]

Description was changed from

==========
Add alpha to resize.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add alpha argument to glResizeCHROMIUM

This lets the compositor specify whether the backbuffer will need to be blended
with the contents behind it, and if not it can use a method that uses less
power.

BUG=561185
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbauman, 2015-12-01 22:53:02]

jbauman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2015-12-02 01:05:13]

LGTM. Is this really something we intend to change dynamically, as opposed to
just choosing at window creation time?

https://codereview.chromium.org/1474873003/diff/20001/cc/output/output_surfac...
File cc/output/output_surface.cc (right):

https://codereview.chromium.org/1474873003/diff/20001/cc/output/output_surfac...
cc/output/output_surface.cc:261: scale_factor, true);
nit: GL_TRUE instead of true

[jbauman, 2015-12-02 01:14:42]

On 2015/12/02 01:05:13, piman (slow to review) wrote:
> LGTM. Is this really something we intend to change dynamically, as opposed to
> just choosing at window creation time?
> 
Yeah, unfortunately it changes between the two when going fullscreen and back,
or when switching between themed and unthemed.

[jbauman, 2015-12-02 02:34:55]

jbauman@chromium.org changed reviewers:
+ bbudge@chromium.org, ben@chromium.org

[jbauman, 2015-12-02 02:34:56]

ben@: mojo/ OWNERS review
bbudge@: ppapi/ OWNERS review

Thanks.

[Ben Goodger (Google), 2015-12-02 02:45:26]

mojo lgtm

[bbudge, 2015-12-02 14:37:44]

ppapi lgtm

[jbauman, 2015-12-02 22:33:36]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2015-12-02 22:33:36]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1474873003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-12-02 22:34:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474873003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474873003/40001

[commit-bot: I haz the power, 2015-12-02 23:15:48]

Description was changed from

==========
Add alpha argument to glResizeCHROMIUM

This lets the compositor specify whether the backbuffer will need to be blended
with the contents behind it, and if not it can use a method that uses less
power.

BUG=561185
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add alpha argument to glResizeCHROMIUM

This lets the compositor specify whether the backbuffer will need to be blended
with the contents behind it, and if not it can use a method that uses less
power.

BUG=561185
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2015-12-02 23:15:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-02 23:18:30]

Description was changed from

==========
Add alpha argument to glResizeCHROMIUM

This lets the compositor specify whether the backbuffer will need to be blended
with the contents behind it, and if not it can use a method that uses less
power.

BUG=561185
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add alpha argument to glResizeCHROMIUM

This lets the compositor specify whether the backbuffer will need to be blended
with the contents behind it, and if not it can use a method that uses less
power.

BUG=561185
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8046f1cbb18126cd9ea1a405c93e545f2c377978
Cr-Commit-Position: refs/heads/master@{#362817}
==========

[commit-bot: I haz the power, 2015-12-02 23:18:31]

Patchset 3 (id:??) landed as
https://crrev.com/8046f1cbb18126cd9ea1a405c93e545f2c377978
Cr-Commit-Position: refs/heads/master@{#362817}