Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1474843003: Revert of Define AudioBuffer and VideoFrame for mojo (Closed)

Created:
5 years ago by raymes
Modified:
5 years ago
Reviewers:
jrummell, xhwang, DaleCurtis
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Define AudioBuffer and VideoFrame for mojo (patchset #4 id:60001 of https://codereview.chromium.org/1468153003/ ) Reason for revert: This looks like it broke the arm buildbot: https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/27229 Original issue's description: > Define AudioBuffer and VideoFrame for mojo > > Adds support so they can be converted to and from the matching classes > in media:: > > BUG=510088 > TEST=new tests pass > > Committed: https://crrev.com/e45d9fa36a51ed750b71b7543563960962d44a90 > Cr-Commit-Position: refs/heads/master@{#361530} TBR=xhwang@chromium.org,dalecurtis@chromium.org,jrummell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510088 Committed: https://crrev.com/9db7df5bc282f4e3d9fb06a0f9ea73e0fbf2d3af Cr-Commit-Position: refs/heads/master@{#361554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -440 lines) Patch
M media/base/audio_buffer.h View 3 chunks +0 lines, -17 lines 0 comments Download
M media/base/audio_buffer.cc View 2 chunks +17 lines, -15 lines 0 comments Download
M media/base/sample_format.h View 1 chunk +0 lines, -6 lines 0 comments Download
M media/base/sample_format.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M media/mojo/interfaces/decryptor.mojom View 1 chunk +4 lines, -0 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +0 lines, -55 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M media/mojo/services/media_type_converters.h View 2 chunks +0 lines, -28 lines 0 comments Download
M media/mojo/services/media_type_converters.cc View 3 chunks +0 lines, -122 lines 0 comments Download
M media/mojo/services/media_type_converters_unittest.cc View 2 chunks +0 lines, -157 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
raymes
Created Revert of Define AudioBuffer and VideoFrame for mojo
5 years ago (2015-11-25 03:36:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474843003/1
5 years ago (2015-11-25 03:38:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 03:41:20 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-25 03:42:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9db7df5bc282f4e3d9fb06a0f9ea73e0fbf2d3af
Cr-Commit-Position: refs/heads/master@{#361554}

Powered by Google App Engine
This is Rietveld 408576698