Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1474803002: Rename SyntheticPointerGesture to SyntheticPointerAction (Closed)

Created:
5 years ago by lanwei
Modified:
5 years ago
Reviewers:
samuong, tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SyntheticPointerGesture to SyntheticPointerAction. SyntheticPointerGesture are low level pointer actions, such as mouse/touch press/move/release, they are not high level gesture, so we rename it to SyntheticPointerAction. BUG=525187 Committed: https://crrev.com/2f41f782b8e1b22c1cb8ced951a6568eab395112 Cr-Commit-Position: refs/heads/master@{#362512}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -138 lines) Patch
M content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc View 5 chunks +24 lines, -21 lines 0 comments Download
A + content/browser/renderer_host/input/synthetic_pointer_action.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + content/browser/renderer_host/input/synthetic_pointer_action.cc View 4 chunks +5 lines, -5 lines 0 comments Download
D content/browser/renderer_host/input/synthetic_pointer_gesture.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/browser/renderer_host/input/synthetic_pointer_gesture.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
lanwei
5 years ago (2015-11-25 14:47:36 UTC) #9
tdresser
LGTM
5 years ago (2015-11-27 14:54:12 UTC) #10
samuong
lgtm
5 years ago (2015-11-30 19:24:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474803002/40001
5 years ago (2015-12-01 19:50:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years ago (2015-12-01 21:52:03 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-01 21:53:34 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f41f782b8e1b22c1cb8ced951a6568eab395112
Cr-Commit-Position: refs/heads/master@{#362512}

Powered by Google App Engine
This is Rietveld 408576698