src/assembler.cc - Issue 1474763008: Always pass an Isolate to AssemblerBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler.cc

Issue 1474763008: Always pass an Isolate to AssemblerBase (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/assembler.cc

diff --git a/src/assembler.cc b/src/assembler.cc

index 5d55fb5f4cde204f90869e86247d16d7fa2a8333..d80f65e6dc3a8adc22fd9c44beb9d0b01c328a24 100644

--- a/src/assembler.cc

+++ b/src/assembler.cc

@@ -173,7 +173,8 @@ AssemblerBase::AssemblerBase(Isolate* isolate, void* buffer, int buffer_size)

// We may use the assembler without an isolate.

serializer_enabled_(isolate && isolate->serializer_enabled()),

constant_pool_available_(false) {

- if (FLAG_mask_constants_with_cookie && isolate != NULL) {

+ DCHECK(isolate);

Michael Starzinger 2015/11/26 17:41:46 nit: DCHECK_NOT_NULL

jochen (gone - plz use gerrit) 2015/11/27 07:55:35 done

+ if (FLAG_mask_constants_with_cookie) {

jit_cookie_ = isolate->random_number_generator()->NextInt();

}

own_buffer_ = buffer == NULL;

« no previous file with comments | « src/assembler.h ('k') | src/debug/arm/debug-arm.cc » ('j') | no next file with comments »