Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: src/debug/arm/debug-arm.cc

Issue 1474763008: Always pass an Isolate to AssemblerBase (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.cc ('k') | src/debug/arm64/debug-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 16 matching lines...) Expand all
27 void DebugCodegen::GenerateSlot(MacroAssembler* masm, RelocInfo::Mode mode, 27 void DebugCodegen::GenerateSlot(MacroAssembler* masm, RelocInfo::Mode mode,
28 int call_argc) { 28 int call_argc) {
29 // Generate enough nop's to make space for a call instruction. Avoid emitting 29 // Generate enough nop's to make space for a call instruction. Avoid emitting
30 // the constant pool in the debug break slot code. 30 // the constant pool in the debug break slot code.
31 Assembler::BlockConstPoolScope block_const_pool(masm); 31 Assembler::BlockConstPoolScope block_const_pool(masm);
32 masm->RecordDebugBreakSlot(mode, call_argc); 32 masm->RecordDebugBreakSlot(mode, call_argc);
33 EmitDebugBreakSlot(masm); 33 EmitDebugBreakSlot(masm);
34 } 34 }
35 35
36 36
37 void DebugCodegen::ClearDebugBreakSlot(Address pc) { 37 void DebugCodegen::ClearDebugBreakSlot(Isolate* isolate, Address pc) {
38 CodePatcher patcher(pc, Assembler::kDebugBreakSlotInstructions); 38 CodePatcher patcher(isolate, pc, Assembler::kDebugBreakSlotInstructions);
39 EmitDebugBreakSlot(patcher.masm()); 39 EmitDebugBreakSlot(patcher.masm());
40 } 40 }
41 41
42 42
43 void DebugCodegen::PatchDebugBreakSlot(Address pc, Handle<Code> code) { 43 void DebugCodegen::PatchDebugBreakSlot(Isolate* isolate, Address pc,
44 Handle<Code> code) {
44 DCHECK_EQ(Code::BUILTIN, code->kind()); 45 DCHECK_EQ(Code::BUILTIN, code->kind());
45 CodePatcher patcher(pc, Assembler::kDebugBreakSlotInstructions); 46 CodePatcher patcher(isolate, pc, Assembler::kDebugBreakSlotInstructions);
46 // Patch the code changing the debug break slot code from 47 // Patch the code changing the debug break slot code from
47 // mov r2, r2 48 // mov r2, r2
48 // mov r2, r2 49 // mov r2, r2
49 // mov r2, r2 50 // mov r2, r2
50 // mov r2, r2 51 // mov r2, r2
51 // to a call to the debug break slot code. 52 // to a call to the debug break slot code.
52 // ldr ip, [pc, #0] 53 // ldr ip, [pc, #0]
53 // b skip 54 // b skip
54 // <debug break slot code entry point address> 55 // <debug break slot code entry point address>
55 // skip: 56 // skip:
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 151
151 152
152 const bool LiveEdit::kFrameDropperSupported = true; 153 const bool LiveEdit::kFrameDropperSupported = true;
153 154
154 #undef __ 155 #undef __
155 156
156 } // namespace internal 157 } // namespace internal
157 } // namespace v8 158 } // namespace v8
158 159
159 #endif // V8_TARGET_ARCH_ARM 160 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/assembler.cc ('k') | src/debug/arm64/debug-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698