Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1474763007: [turbofan] Test has been outsmarted by optimization. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Test has been outsmarted by optimization. The fast-prototype test has been outsmarted by constructor inlining because the instantiation is been correctly optimized away. Internal state introspection about prototype turning fast was upset by that. R=bmeurer@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/69227cc192df18aa9a477b5c221a6b70fa56854a Cr-Commit-Position: refs/heads/master@{#32338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M test/mjsunit/fast-prototype.js View 1 chunk +3 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years ago (2015-11-26 13:44:26 UTC) #1
Benedikt Meurer
LGTM :-)
5 years ago (2015-11-26 13:44:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474763007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474763007/1
5 years ago (2015-11-26 13:53:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 14:03:51 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-26 14:04:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69227cc192df18aa9a477b5c221a6b70fa56854a
Cr-Commit-Position: refs/heads/master@{#32338}

Powered by Google App Engine
This is Rietveld 408576698