Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1474733002: Add print_stacktrace=1 to ubsan defaults. (Closed)

Created:
5 years ago by pbos
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add print_stacktrace=1 to ubsan defaults. Also using a no_sanitize list for SANITIZER_HOOK_ATTRIBUTE instead of separate attributes per tool. BUG= R=glider@chromium.org Committed: https://crrev.com/51b0910409e6a0ee60a4253ebf54f0fcf3711831 Cr-Commit-Position: refs/heads/master@{#361376}

Patch Set 1 #

Patch Set 2 : __ubsan_default_options #

Patch Set 3 : use print_stacktrace=1, oops #

Patch Set 4 : cl format #

Patch Set 5 : close no_sanitize parenthesis #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M build/sanitizers/sanitizer_options.cc View 1 2 3 4 3 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
pbos
__ubsan_default_options
5 years ago (2015-11-24 15:05:09 UTC) #1
pbos
use print_stacktrace=1, oops
5 years ago (2015-11-24 15:06:29 UTC) #2
pbos
PTAL
5 years ago (2015-11-24 15:08:47 UTC) #3
pbos
cl format
5 years ago (2015-11-24 15:10:02 UTC) #5
pbos
close no_sanitize parenthesis
5 years ago (2015-11-24 15:11:45 UTC) #6
pbos
On 2015/11/24 15:11:45, pbos wrote: > close no_sanitize parenthesis (This was emailed out as print_suppressions=1, ...
5 years ago (2015-11-24 15:15:29 UTC) #7
Alexander Potapenko
LGTM
5 years ago (2015-11-24 16:17:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474733002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474733002/80001
5 years ago (2015-11-24 16:28:12 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-11-24 17:12:47 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-24 17:13:45 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/51b0910409e6a0ee60a4253ebf54f0fcf3711831
Cr-Commit-Position: refs/heads/master@{#361376}

Powered by Google App Engine
This is Rietveld 408576698