Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1474713005: [base] fcntl, not fctnl. (Closed)

Created:
5 years ago by Scott Hess - ex-Googler
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[base] fcntl, not fctnl. "fctnl" was breaking my brain. Then I saw the static-in-anonymous-namespace. BUG=none Committed: https://crrev.com/8f5f5dbfbee328fe74f0c20a8f7e8384a818a778 Cr-Commit-Position: refs/heads/master@{#361586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M base/files/file_posix.cc View 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Scott Hess - ex-Googler
Stopped myself before changing to CallFcntlLock() [because it's not flock()] or DoLock() [because why would ...
5 years ago (2015-11-24 23:32:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474713005/1
5 years ago (2015-11-24 23:38:05 UTC) #4
Lei Zhang
lgtm
5 years ago (2015-11-24 23:39:07 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 03:48:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474713005/1
5 years ago (2015-11-25 05:38:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 05:44:07 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-25 05:45:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f5f5dbfbee328fe74f0c20a8f7e8384a818a778
Cr-Commit-Position: refs/heads/master@{#361586}

Powered by Google App Engine
This is Rietveld 408576698