Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart

Issue 1474713002: dart2js cps: Clean up and avoid processing unreachable code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merge Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
diff --git a/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart b/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
index 4f0be4ad41428b4d8f3bb5a075004aaa377178a1..b4f6dd88014dc0849bca5b55a1970e0bb9326367 100644
--- a/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
+++ b/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
@@ -63,11 +63,6 @@ class LogicalRewriter extends RecursiveTransformer
final FallthroughStack fallthrough = new FallthroughStack();
- @override
- void visitInnerFunction(FunctionDefinition node) {
- new LogicalRewriter().rewrite(node);
- }
-
/// True if the given statement is equivalent to its fallthrough semantics.
///
/// This means it will ultimately translate to an empty statement.
@@ -543,9 +538,9 @@ class LogicalRewriter extends RecursiveTransformer
}
}
- /// True if [e2] is known to return the same value as [e1]
+ /// True if [e2] is known to return the same value as [e1]
/// (with no additional side effects) if evaluated immediately after [e1].
- ///
+ ///
/// Concretely, this is true if [e1] and [e2] are uses of the same variable,
/// or if [e2] is a use of a variable assigned by [e1].
bool isSameVariable(Expression e1, Expression e2) {
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/unsugar.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698