Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1474713002: dart2js cps: Clean up and avoid processing unreachable code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merge Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 25557a9ae81810308d223f8361a86f67da8eeda2..487eb4508fd26b79eba8879da264ec83b0baac8f 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -1075,12 +1075,6 @@ class CodeGenerator extends tree_ir.StatementVisitor
return new js.Await(visitExpression(node.input));
}
- visitFunctionExpression(tree_ir.FunctionExpression node) {
- // FunctionExpressions are currently unused.
- // We might need them if we want to emit raw JS nested functions.
- throw 'FunctionExpressions should not be used';
- }
-
/// Ensures that parameter defaults will be emitted.
///
/// Ideally, this should be done when generating the relevant stub methods,
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_propagation.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/unsugar.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698