pkg/compiler/lib/src/cps_ir/gvn.dart - Issue 1474713002: dart2js cps: Clean up and avoid processing unreachable code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/gvn.dart

Issue 1474713002: dart2js cps: Clean up and avoid processing unreachable code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Merge Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/gvn.dart

diff --git a/pkg/compiler/lib/src/cps_ir/gvn.dart b/pkg/compiler/lib/src/cps_ir/gvn.dart

index ada9f2428b0a7b49452d85da72f82c3d05f69760..02379d85c1a5e3493d6acda9c84e6beb317f30f5 100644

--- a/pkg/compiler/lib/src/cps_ir/gvn.dart

+++ b/pkg/compiler/lib/src/cps_ir/gvn.dart

@@ -596,11 +596,8 @@ class GvnVectorBuilder extends DeepRecursiveVisitor {

vector.add(gvnFor[prim] ?? prim);

}

- visitTypeTest(TypeTest node) {

+ processTypeTest(TypeTest node) {

vector = [GvnCode.TYPE_TEST, node.dartType];

- processReference(node.value);

- node.typeArguments.forEach(processReference);

- // Suppress processing of the interceptor argument.

}

processTypeTestViaFlag(TypeTestViaFlag node) {