[heap] delete Heap::LeftTrimFixedAray

[heap] delete Heap::LeftTrimFixedAray

No more uses left for this code (thank goodness.)

R=hpayer@chromium.org
BUG=

Committed: https://crrev.com/dc3442b1ec803916eb6c1882ab4c3ec6fd44dd55
Cr-Commit-Position: refs/heads/master@{#32305}

[Michael Lippautz, 2015-11-24 19:08:21]

mlippautz@chromium.org changed reviewers:
+ mlippautz@chromium.org

[Michael Lippautz, 2015-11-24 19:08:21]

dbc: We prepared removing this code ~3 months ago. If we get rid of it now, we
should probably also get rid of 
* Heap::CanMoveObjectStart, and
* FLAG_move_object_start
in this CL.

[ofrobots, 2015-11-24 19:22:13]

On 2015/11/24 19:08:21, Michael Lippautz wrote:
> dbc: We prepared removing this code ~3 months ago. If we get rid of it now, we
> should probably also get rid of 
> * Heap::CanMoveObjectStart, and
> * FLAG_move_object_start
> in this CL.

I've updated the CL to also remove CanMoveObjectStart and
FLAG_move_object_start.

[Hannes Payer (out of office), 2015-11-25 09:34:03]

On 2015/11/24 19:22:13, ofrobots wrote:
> On 2015/11/24 19:08:21, Michael Lippautz wrote:
> > dbc: We prepared removing this code ~3 months ago. If we get rid of it now,
we
> > should probably also get rid of 
> > * Heap::CanMoveObjectStart, and
> > * FLAG_move_object_start
> > in this CL.
> 
> I've updated the CL to also remove CanMoveObjectStart and
> FLAG_move_object_start.

Since somebody apparently already deleted the caller, LGTM :)

[Michael Lippautz, 2015-11-25 09:47:51]

lgtm w/ one more dead code deletion ;)

https://codereview.chromium.org/1474693003/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (left):

https://codereview.chromium.org/1474693003/diff/20001/src/heap/heap.cc#oldcod...
src/heap/heap.cc:3138: Marking::TransferMark(this, object->address(),
new_start);
You can also remove Marking::TransferMark.

[ofrobots, 2015-11-25 19:32:09]

https://codereview.chromium.org/1474693003/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (left):

https://codereview.chromium.org/1474693003/diff/20001/src/heap/heap.cc#oldcod...
src/heap/heap.cc:3138: Marking::TransferMark(this, object->address(),
new_start);
On 2015/11/25 09:47:51, Michael Lippautz wrote:
> You can also remove Marking::TransferMark.

Done.

[ofrobots, 2015-11-25 19:32:13]

The CQ bit was checked by ofrobots@google.com

[ofrobots, 2015-11-25 19:32:13]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/1474693003/#ps40001
(title: "also delete Marking::TransferMark")

[commit-bot: I haz the power, 2015-11-25 19:32:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474693003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474693003/40001

[commit-bot: I haz the power, 2015-11-25 20:25:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-25 20:26:05]

Description was changed from

==========
[heap] delete Heap::LeftTrimFixedAray

No more uses left for this code (thank goodness.)

R=hpayer@chromium.org
BUG=
==========

to

==========
[heap] delete Heap::LeftTrimFixedAray

No more uses left for this code (thank goodness.)

R=hpayer@chromium.org
BUG=

Committed: https://crrev.com/dc3442b1ec803916eb6c1882ab4c3ec6fd44dd55
Cr-Commit-Position: refs/heads/master@{#32305}
==========

[commit-bot: I haz the power, 2015-11-25 20:26:06]

Patchset 3 (id:??) landed as
https://crrev.com/dc3442b1ec803916eb6c1882ab4c3ec6fd44dd55
Cr-Commit-Position: refs/heads/master@{#32305}

[Michael Lippautz, 2015-12-18 08:36:43]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1535933002/ by mlippautz@chromium.org.

The reason for reverting is: Revive left-trimming until new strategies are
evaluated and decided on.

BUG=v8:4606
LOG=N.