XFA: more underlying type changes to match master

XFA: more underlying type changes to match master

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/540c436dc8e7d7b700b448acc8536f5cf68d4b74

[Tom Sepez, 2015-11-24 20:52:31]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-11-24 20:52:32]

Mostly additional use of underlyingtype, but some changes to make things align
better with master (e.g. early returns allow statements to line up at the same
indent level).

[Tom Sepez, 2015-11-24 21:00:35]

https://codereview.chromium.org/1474663004/diff/1/fpdfsdk/src/fpdfformfill.cpp
File fpdfsdk/src/fpdfformfill.cpp (right):

https://codereview.chromium.org/1474663004/diff/1/fpdfsdk/src/fpdfformfill.cp...
fpdfsdk/src/fpdfformfill.cpp:132: const int kRequiredVersion = 2;
e.g. will avoid an ifdef in the middle of a no-{} if.

[Lei Zhang, 2015-11-24 21:22:44]

lgtm

This mostly look strangely familiar...

https://codereview.chromium.org/1474663004/diff/1/fpdfsdk/src/fpdfformfill.cpp
File fpdfsdk/src/fpdfformfill.cpp (right):

https://codereview.chromium.org/1474663004/diff/1/fpdfsdk/src/fpdfformfill.cp...
fpdfsdk/src/fpdfformfill.cpp:132: const int kRequiredVersion = 2;
On 2015/11/24 21:00:34, Tom Sepez wrote:
> e.g. will avoid an ifdef in the middle of a no-{} if.

Acknowledged.

[Tom Sepez, 2015-11-24 21:34:00]

Committed patchset #1 (id:1) manually as
540c436dc8e7d7b700b448acc8536f5cf68d4b74 (presubmit successful).