Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 14746017: add wildcard test name matching to gm (Closed)

Created:
7 years, 7 months ago by caryclark
Modified:
7 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add wildcard test name matching to gm and bench. This adds the same set of options in unit tests, i.e: --match [~][^]match[$] [~][^]match[$] ... ~ causes a matching test to always be skipped ^ requires the start of the test to match $ requires the end of the test to match ^ and $ requires an exact match If a test does not match any list entry, it is skipped unless some list entry starts with ~ Committed: https://code.google.com/p/skia/source/detail?r=9096

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -22 lines) Patch
M bench/benchmain.cpp View 1 3 chunks +39 lines, -12 lines 0 comments Download
M gm/gmmain.cpp View 2 chunks +34 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caryclark
7 years, 7 months ago (2013-05-10 13:36:59 UTC) #1
bsalomon
lgtm
7 years, 7 months ago (2013-05-10 13:57:57 UTC) #2
caryclark
added bench as well
7 years, 7 months ago (2013-05-10 14:59:34 UTC) #3
bsalomon
On 2013/05/10 14:59:34, caryclark wrote: > added bench as well looks even better to me
7 years, 7 months ago (2013-05-10 15:12:10 UTC) #4
caryclark
7 years, 7 months ago (2013-05-10 15:16:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r9096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698