Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/proxy/proxy_resolver_v8.cc

Issue 14746011: Use Persistent::Reset. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: code review (jochen) Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/scoped_persistent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_v8.cc
diff --git a/net/proxy/proxy_resolver_v8.cc b/net/proxy/proxy_resolver_v8.cc
index 8ab15fcf9221be86acde7a03ae9e99e064af6d5b..c94725003e6d8ff7ea1acb8d4fdb0c249c83524b 100644
--- a/net/proxy/proxy_resolver_v8.cc
+++ b/net/proxy/proxy_resolver_v8.cc
@@ -404,8 +404,7 @@ class ProxyResolverV8::Context {
v8::Locker locked(isolate_);
v8::HandleScope scope;
- v8_this_ = v8::Persistent<v8::External>::New(isolate_,
- v8::External::New(this));
+ v8_this_.Reset(isolate_, v8::External::New(this));
v8::Local<v8::ObjectTemplate> global_template = v8::ObjectTemplate::New();
// Attach the javascript bindings.
@@ -445,7 +444,7 @@ class ProxyResolverV8::Context {
global_template->Set(ASCIILiteralToV8String("isInNetEx"),
is_in_net_ex_template);
- v8_context_ = v8::Persistent<v8::Context>::New(
+ v8_context_.Reset(
isolate_, v8::Context::New(isolate_, NULL, global_template));
v8::Context::Scope ctx(v8_context_);
« no previous file with comments | « chrome/renderer/extensions/scoped_persistent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698