Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1474593002: DevTools: Make tracking flamechart info never go outside the window (Closed)

Created:
5 years ago by alph
Modified:
5 years ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make tracking flamechart info never go outside the window BUG=528489 Committed: https://crrev.com/b5120caf7d30748f02d25880500fee814a468679 Cr-Commit-Position: refs/heads/master@{#361251}

Patch Set 1 #

Patch Set 2 : remove extra assignments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -27 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 1 2 chunks +43 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/flameChart.css View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
alph
5 years ago (2015-11-24 02:18:32 UTC) #2
caseq
lgtm
5 years ago (2015-11-24 02:25:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474593002/20001
5 years ago (2015-11-24 02:36:14 UTC) #5
paulirish
Nice. Lookin good
5 years ago (2015-11-24 02:59:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 04:09:18 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-24 04:10:05 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b5120caf7d30748f02d25880500fee814a468679
Cr-Commit-Position: refs/heads/master@{#361251}

Powered by Google App Engine
This is Rietveld 408576698