Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1474573002: [Chromecast] Ignore MonitorLoop if EOS in unit test (Closed)

Created:
5 years, 1 month ago by yucliu1
Modified:
5 years ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Ignore MonitorLoop if EOS in unit test According to specification in media_pipeline_backend.h, GetCurrentPts is only allowed to be called when backend is in playing/paused state. Thus we shouldn't call the function after backend is stopped. BUG=internal b/25852465 Committed: https://crrev.com/e16a7d3b1c2a6b0cfa9a240e7fdfa8cdda0729c7 Cr-Commit-Position: refs/heads/master@{#361400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yucliu1
5 years, 1 month ago (2015-11-24 01:49:05 UTC) #3
kmackay
lgtm
5 years, 1 month ago (2015-11-24 03:10:43 UTC) #4
halliwell
On 2015/11/24 03:10:43, kmackay wrote: > lgtm lgtm
5 years, 1 month ago (2015-11-24 03:52:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474573002/1
5 years ago (2015-11-24 18:09:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 18:43:30 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-24 18:45:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e16a7d3b1c2a6b0cfa9a240e7fdfa8cdda0729c7
Cr-Commit-Position: refs/heads/master@{#361400}

Powered by Google App Engine
This is Rietveld 408576698