Make CapabilityFilter non-nullable.

Make CapabilityFilter non-nullable.

Passing null to the Shell interface means to run the application with a permissive filter. This is confusing compared to passing an empty CapabilityFilter which means run with the most restrictive filter. One should have to explicitly construct a permissive filter.

R=sky@chromium.org
BUG=

Committed: https://crrev.com/0a62ff059aa3b09b08a93b85135ef945ea0edf3a
Cr-Commit-Position: refs/heads/master@{#361596}

[sky, 2015-11-24 00:24:05]

LGTM

[Ben Goodger (Google), 2015-11-24 00:24:54]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2015-11-24 00:27:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474563002/1

[commit-bot: I haz the power, 2015-11-24 01:39:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 01:39:47]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Ben Goodger (Google), 2015-11-24 05:01:31]

I had to update the client lib:
- initialize ConnectParams::filter_ to non-null
- adjust the C2A("string") function to pass a permissive filter.

[sky, 2015-11-24 16:22:13]

SLGTM

[Ben Goodger (Google), 2015-11-24 21:41:20]

Now tests pass too. PTAL.

[Ben Goodger (Google), 2015-11-24 21:42:17]

Patchset #3 (id:40001) has been deleted

[Ben Goodger (Google), 2015-11-24 21:46:11]

Description was changed from

==========
Make CapabilityFilter non-nullable.

It turns out no one passes null, and the default value of null (run with
permissive filter) is very confusing as it is at odds with constructing an empty
CapabilityFilter (allow nothing).

R=sky@chromium.org
BUG=
==========

to

==========
Make CapabilityFilter non-nullable.

Passing null to the Shell interface means to run the application with a
permissive filter. This is confusing compared to passing an empty
CapabilityFilter which means run with the most restrictive filter. One should
have to explicitly construct a permissive filter.

R=sky@chromium.org
BUG=
==========

[sky, 2015-11-24 21:47:04]

LGTM

[Ben Goodger (Google), 2015-11-25 02:44:44]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-11-25 02:44:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1474563002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2015-11-25 02:47:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474563002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474563002/80001

[commit-bot: I haz the power, 2015-11-25 03:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 03:38:07]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2015-11-25 04:54:47]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-11-25 04:54:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1474563002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2015-11-25 04:55:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474563002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474563002/100001

[commit-bot: I haz the power, 2015-11-25 06:42:33]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-11-25 06:43:54]

Patchset 5 (id:??) landed as
https://crrev.com/0a62ff059aa3b09b08a93b85135ef945ea0edf3a
Cr-Commit-Position: refs/heads/master@{#361596}