Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1474543005: Removed support deprecated (//@|/*@) source(URL|MappingURL)= (Closed)

Created:
5 years ago by kozy
Modified:
5 years ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed support deprecated (//@|/*@) source(URL|MappingURL)= LOG=Y BUG=chromium:558998 R=yangguo@chromium.org Committed: https://crrev.com/c1e5f005d79c436d90f474f8bc6448c4555a619f Cr-Commit-Position: refs/heads/master@{#32249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -31 lines) Patch
M include/v8.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/js/messages.js View 1 chunk +3 lines, -4 lines 0 comments Download
M src/scanner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M test/mjsunit/regress/regress-conditional-position.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-109362.js View 2 chunks +10 lines, -10 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-481896.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-517592.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/stack-traces.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
kozy
Yang, please take a look.
5 years ago (2015-11-25 02:11:59 UTC) #2
Yang
On 2015/11/25 02:11:59, kozyatinskiy wrote: > Yang, please take a look. lgtm.
5 years ago (2015-11-25 07:43:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474543005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474543005/1
5 years ago (2015-11-25 07:59:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 08:01:54 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c1e5f005d79c436d90f474f8bc6448c4555a619f Cr-Commit-Position: refs/heads/master@{#32249}
5 years ago (2015-11-25 08:02:35 UTC) #7
Michael Achenbach
Any chance that this changes layout tests? E.g. see: https://build.chromium.org/p/client.v8.fyi/console?branch=master It's a bit difficult to ...
5 years ago (2015-11-25 10:11:53 UTC) #9
Michael Achenbach
+ hablich
5 years ago (2015-11-25 10:12:09 UTC) #10
Yang
On 2015/11/25 10:12:09, Michael Achenbach wrote: > + hablich It definitely might. You definitely can ...
5 years ago (2015-11-25 10:25:06 UTC) #11
Yang
5 years ago (2015-11-25 10:26:57 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1481513002/ by yangguo@chromium.org.

The reason for reverting is: Failing layout tests:

inspector/tracing/timeline-event-causes.html
virtual/syncpaint/inspector/tracing/timeline-event-causes.html
inspector/animation/animation-timeline-fill.html
virtual/threaded/inspector/tracing/timeline-event-causes.html
inspector/tracing/timeline-script-id.html
inspector/sources/debugger-ui/source-url-comment.html
inspector/console/console-log-linkify-stack-in-errors.html
virtual/syncpaint/inspector/tracing/timeline-script-id.html
virtual/threaded/inspector/tracing/timeline-script-id.html.

Powered by Google App Engine
This is Rietveld 408576698