Implement Fast Accessor Builder

src/compiler/fast-accessor-assembler.h

+// Copyright 2015 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8_COMPILER_FAST_ACCESSOR_ASSEMBLER_H_
+#define V8_COMPILER_FAST_ACCESSOR_ASSEMBLER_H_
+
+#include <stdint.h>
+#include <vector>
+
+#include "src/base/macros.h"
+#include "src/base/smart-pointers.h"
+#include "src/handles.h"
+
+
+namespace v8 {
+namespace internal {
+
+class Code;
+class Isolate;
+class Zone;
+
+namespace compiler {
+
+class CallDescriptor;
+class Label;
+class Node;
+class RawMachineAssembler;
+
+// This interface "exports" an aggregated subset of RawMachineAssembler, for
+// use by the API to implement Fast Dom Accessors. (crbug.com/508898).
+//
+// This interface is made for this single purpose only and does not attempt
+// to implement a general purpose solution. If you need one, please look at
+// RawMachineAssembler instead.
+//
+// The life cycle of a FastAccessorAssembler has two phases:
+// - After creating the instance, you can call an arbitrary sequence of
+//   builder functions to build the desired function.
+// - When done, you can Build() the accessor and query for the build results.
+// You cannot call any result getters before Build() was called & successful;
+// and you cannot call any builder functions after Build() was called.
+class FastAccessorAssembler {
+ public:
+  typedef size_t ValueId;

[epertoso, 2015/11/25 10:31:16]

vector<Node*>::size_type would be more accurate.

+
+  explicit FastAccessorAssembler(Isolate* isolate);
+  ~FastAccessorAssembler();
+
+  // Builder / assembler functions:

[epertoso, 2015/11/25 10:31:16]

GetInternalField, LoadObject, CheckFlagsSetOrReturnNull, SetLabel,
ChecNotNullOrJump are not implemented.

+  ValueId IntegerConstant(int int_constant);
+  ValueId GetParameter(size_t parameter_no);
+  ValueId GetInternalField(ValueId value_id, int field_no);
+  ValueId LoadValue(ValueId value_id, int offset);
+  ValueId LoadObject(ValueId value_id, int offset);
+  // .. call native.
+  // .. throw exception
+
+  // Builder / assembler functions for control flow.
+  void ReturnValue(ValueId);
+  void CheckFlagSetOrReturnNull(ValueId value_id, int mask);
+  void CheckNotNullOrReturnNull(ValueId value_id);
+  //  void CheckNotNullOrCallback(ValueId value_id, ..c++-callback type...,
+  //  ValueId arg1, ValueId arg2, ...);
+  ValueId SetLabel();
+  void CheckNotNullOrJump(ValueId value_id, ValueId label_id);
+
+  // Assemble the code.
+  Handle<Code> Build();
+
+  // Obtain build results:
+  CallDescriptor* GetCallDescriptor() const;
+  //... GetGraph, Schedule, call descriptor ???
+
+
+ private:
+  ValueId FromNode(Node* node);
+  ValueId FromLabel(Label* label);

[epertoso, 2015/11/25 10:31:15]

FromLabel and LabelFromValue are not implemented.

+  Node* FromValue(ValueId value) const;
+  Label* LabelFromValue(ValueId value) const;
+
+  Zone* zone() { return &zone_; }
+
+  Zone zone_;
+  base::SmartPointer<RawMachineAssembler> assembler_;
+
+  // To prevent exposing the RMA internals to the outside world, we'll map
+  // Node + Label pointers to ValueId integers, and use two vectors to
+  // remember + check them.
+  // Since ValueIds can map to either nodes_ or labels_, we can't use the
+  // same slot for both.
+  std::vector<Node*> nodes_;
+  std::vector<Label*> labels_;

[epertoso, 2015/11/25 10:31:16]

You're never using labels_, are you?

+
+  // Remember the current state for easy error checking. (We prefer to be
+  // strict as this class will be exposed at the API.)
+  enum { BUILDING, BUILT, ERROR } state_;
+
+  DISALLOW_COPY_AND_ASSIGN(FastAccessorAssembler);
+};
+
+}  // namespace compiler
+}  // namespace internal
+}  // namespace v8
+
+#endif  // V8_COMPILER_FAST_ACCESSOR_ASSEMBLER_H_