Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: components/mus/public/interfaces/window_tree.mojom

Issue 1474543002: Makes NewWindow() take set of properties for window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nuke shadow_style changes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/mus/public/interfaces/window_manager.mojom ('k') | components/mus/ws/connection_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/mus/public/interfaces/window_tree.mojom
diff --git a/components/mus/public/interfaces/window_tree.mojom b/components/mus/public/interfaces/window_tree.mojom
index 7c57d2f085744dd323aa9088cc4253661a763ee1..f0c619f964d6c5730d2d7bddc9d7fd68dcc541e7 100644
--- a/components/mus/public/interfaces/window_tree.mojom
+++ b/components/mus/public/interfaces/window_tree.mojom
@@ -86,10 +86,9 @@ interface WindowTree {
// ERROR_CODE_VALUE_IN_USE: a window already exists with the specified id.
// ERROR_CODE_ILLEGAL_ARGUMENT: The connection part of |window_id| does not
// match the connection id of the client.
- //
- // TODO(erg): Once we have default values in mojo, make this take a map of
- // properties.
- NewWindow(uint32 change_id, uint32 window_id);
+ NewWindow(uint32 change_id,
+ uint32 window_id,
+ map<string, array<uint8>>? properties);
// Deletes a window. This does not recurse. No hierarchy change notifications
// are sent as a result of this. Only the connection that created the window
« no previous file with comments | « components/mus/public/interfaces/window_manager.mojom ('k') | components/mus/ws/connection_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698